[17.0][MIG] mail_quoted_reply: Migration to 17.0 #1354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ocabot migration mail_quoted_reply |
hbrunn
requested changes
Apr 22, 2024
| res = super()._compute_body() | ||
| for composer in self: | ||
| context = composer._context | ||
| if "is_quoted_reply" in context.keys() and context["is_quoted_reply"]: |
There was a problem hiding this comment.
Suggested change
| if "is_quoted_reply" in context.keys() and context["is_quoted_reply"]: | |
| if context.get("is_quoted_reply"): |
| result["subject"] = tools.ustr(subj) | ||
| return result | ||
| @api.depends( | ||
| "composition_mode", "model", "parent_id", "res_domain", "res_ids", "template_id" |
There was a problem hiding this comment.
why do you remove record_name here?
trisdoan
force-pushed
the
17.0-mig-mail_quoted_reply
branch
4 times, most recently
from
dabd555 to
0efb748
Compare
|
Hello @hbrunn, I updated as you suggest 🙏 |
Currently translated at 100.0% (8 of 8 strings) Translation: social-14.0/social-14.0-mail_quoted_reply Translate-URL: https://translation.odoo-community.org/projects/social-14-0/social-14-0-mail_quoted_reply/ca/
Currently translated at 100.0% (8 of 8 strings) Translation: social-14.0/social-14.0-mail_quoted_reply Translate-URL: https://translation.odoo-community.org/projects/social-14-0/social-14-0-mail_quoted_reply/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: social-15.0/social-15.0-mail_quoted_reply Translate-URL: https://translation.odoo-community.org/projects/social-15-0/social-15-0-mail_quoted_reply/
Completed the migration to 16.0 incl. the upgrade to the OWL framework to make it more lean and reliable for the future.
This commit adds functionality to include the original subject of a message when composing a quoted reply. The `get_record_data` method in the `MailComposeMessage` model has been updated to check if there is a default subject and, if so, prepend "Re: " to it. This ensures that the new subject for the quoted reply includes a "Re:" prefix.
_prep_quoted_reply_body. put the format date in the env format [15][IMP]mail_quoted_reply: Added signature, and translate fields Make it: From, Date, Subject Strings translate Addded User Signature Update mail_message.py Update CONTRIBUTORS.rst
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: social-16.0/social-16.0-mail_quoted_reply Translate-URL: https://translation.odoo-community.org/projects/social-16-0/social-16-0-mail_quoted_reply/
Without this, it is not possible to do a copy paste of a block of text into the mail composer.
Currently translated at 100.0% (6 of 6 strings) Translation: social-16.0/social-16.0-mail_quoted_reply Translate-URL: https://translation.odoo-community.org/projects/social-16-0/social-16-0-mail_quoted_reply/es/
Currently translated at 100.0% (6 of 6 strings) Translation: social-16.0/social-16.0-mail_quoted_reply Translate-URL: https://translation.odoo-community.org/projects/social-16-0/social-16-0-mail_quoted_reply/it/
trisdoan
force-pushed
the
17.0-mig-mail_quoted_reply
branch
from
0efb748 to
adc2c86
Compare
hbrunn
approved these changes
May 6, 2024
mmequignon
reviewed
May 15, 2024
| def _compute_subject(self): | ||
| res = super()._compute_subject() | ||
| for composer in self: | ||
| subj = composer._context.get("default_subject", False) |
| res = super()._compute_body() | ||
| for composer in self: | ||
| context = composer._context | ||
| if context.get("is_quoted_reply"): |
There was a problem hiding this comment.
since it appears to depend on a context key, aren't we supposed to add this key in @api.depends_context() ?
|
Hello @mmequignon, I updated as you suggest, thanks |
jaenbox
reviewed
Jul 11, 2024
| for composer in self: | ||
| context = composer._context | ||
| if context.get("is_quoted_reply"): | ||
| composer.body = Markup(context["quote_body"]) |
There was a problem hiding this comment.
It should be noted that when a user replies to a message and wants to load a template from the template_id field, the template must be added to the content that we already have in the body.
You can fix this with this code since the body in the creation of mail.compose.message is False.
if context.get("is_quoted_reply"): if composer.body: composer.body += Markup(context["quote_body"]) else: composer.body = Markup(context["quote_body"])
thomaspot
pushed a commit
to open2bizz/social
that referenced
this pull request
Aug 15, 2024
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major changes in V17
_onchange_template_id+default_get+get_record_datausage into editablecomputed stored fields in here
_evaluate_res_idsis introduced to parse composer res_ids in here. As consequence, 'default_res_id' is deprecated, should use 'default_res_ids'.Components: