[17.0] [MIG] mail_layout_preview: Migration to 17.0 #1371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently translated at 100.0% (14 of 14 strings) Translation: social-16.0/social-16.0-mail_layout_preview Translate-URL: https://translation.odoo-community.org/projects/social-16-0/social-16-0-mail_layout_preview/es/
Currently translated at 100.0% (14 of 14 strings) Translation: social-16.0/social-16.0-mail_layout_preview Translate-URL: https://translation.odoo-community.org/projects/social-16-0/social-16-0-mail_layout_preview/it/
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
github-actions
bot
removed
the
stale
ivantodorovich
approved these changes
Nov 4, 2024
| url_pattern = "/email-preview/res.partner/mail.email_template_partner/{}" | ||
| for el, tmpl in zip(list_items, templates): | ||
| url_pattern = "/email-preview/res.partner/{templ_id}" | ||
| for el, tmpl in zip(list_items, templates, strict=False): |
There was a problem hiding this comment.
isn't False the default value for strict ?
If so, I see no point for this line diff
|
/ocabot migration mail_layout_preview |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at 3fe95cb. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.