-
-
Notifications
You must be signed in to change notification settings - Fork 618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
17 mig mail quoted reply #1456
Open
jaenbox
wants to merge
38
commits into
OCA:17.0
Choose a base branch
from
Ontinet-com:17-mig-mail_quoted_reply
base: 17.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
17 mig mail quoted reply #1456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently translated at 100.0% (8 of 8 strings) Translation: social-14.0/social-14.0-mail_quoted_reply Translate-URL: https://translation.odoo-community.org/projects/social-14-0/social-14-0-mail_quoted_reply/ca/
Currently translated at 100.0% (8 of 8 strings) Translation: social-14.0/social-14.0-mail_quoted_reply Translate-URL: https://translation.odoo-community.org/projects/social-14-0/social-14-0-mail_quoted_reply/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: social-15.0/social-15.0-mail_quoted_reply Translate-URL: https://translation.odoo-community.org/projects/social-15-0/social-15-0-mail_quoted_reply/
Completed the migration to 16.0 incl. the upgrade to the OWL framework to make it more lean and reliable for the future.
This commit adds functionality to include the original subject of a message when composing a quoted reply. The `get_record_data` method in the `MailComposeMessage` model has been updated to check if there is a default subject and, if so, prepend "Re: " to it. This ensures that the new subject for the quoted reply includes a "Re:" prefix.
_prep_quoted_reply_body. put the format date in the env format [15][IMP]mail_quoted_reply: Added signature, and translate fields Make it: From, Date, Subject Strings translate Addded User Signature Update mail_message.py Update CONTRIBUTORS.rst
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: social-16.0/social-16.0-mail_quoted_reply Translate-URL: https://translation.odoo-community.org/projects/social-16-0/social-16-0-mail_quoted_reply/
Without this, it is not possible to do a copy paste of a block of text into the mail composer.
Currently translated at 100.0% (6 of 6 strings) Translation: social-16.0/social-16.0-mail_quoted_reply Translate-URL: https://translation.odoo-community.org/projects/social-16-0/social-16-0-mail_quoted_reply/es/
Currently translated at 100.0% (6 of 6 strings) Translation: social-16.0/social-16.0-mail_quoted_reply Translate-URL: https://translation.odoo-community.org/projects/social-16-0/social-16-0-mail_quoted_reply/it/
@jaenbox Thanks for the mig. Can you please get this commit as well? |
As we are adding HTML from external messages into the mail composer HTML widget, we do not control what is in there and it could break the webclient or making it unresponsive depending on its content. Sanitizing the body of the quoted message might not solve all the issues, but it at least provides a hook for extra processing.
grindtildeath
approved these changes
Nov 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
supersede #1354