Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.0][MIG] mail_notification_with_history: Migration to 18.0 #1463

Merged

Conversation

trisdoan
Copy link

@trisdoan trisdoan commented Oct 10, 2024

Note

  • template message_notification_email was moved to data/mail_templates.xml in odoo/odoo@78c68f4

  • Later splitted for better isolate notification layouts in odoo/odoo@a480f1f

This change

  • Since t-raw was flagged as deprecated, replace it with t-out

Result

mail_notification_migration

Copy link

@henrybackman henrybackman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG with one minor comment

<ul>
<t t-foreach="message_history" t-as="msg">
<li class="message_history_item">
<p><t t-esc="msg.author_id.name or 'unknown'" /> commented on <span

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

t-esc is soft deprecated, could we switch to t-out here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to be addressed

@trisdoan trisdoan force-pushed the 18.0-mig-mail_notification_with_history branch 3 times, most recently from 76023ba to 7f492cd Compare October 28, 2024 07:13
@trisdoan trisdoan force-pushed the 18.0-mig-mail_notification_with_history branch from 7f492cd to e3cb4ad Compare October 28, 2024 07:19
@trisdoan trisdoan requested a review from simahawk October 28, 2024 07:22
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@simahawk
Copy link
Contributor

simahawk commented Nov 4, 2024

/ocabot migration mail_notification_with_history
/ocabot merge nobump

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Nov 4, 2024
@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 18.0-ocabot-merge-pr-1463-by-simahawk-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit aba78a8 into OCA:18.0 Nov 4, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at c2442a9. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants