-
-
Notifications
You must be signed in to change notification settings - Fork 618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[18.0][MIG] mail_notification_with_history: Migration to 18.0 #1463
[18.0][MIG] mail_notification_with_history: Migration to 18.0 #1463
Conversation
bc11c31
to
12ffd03
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG with one minor comment
<ul> | ||
<t t-foreach="message_history" t-as="msg"> | ||
<li class="message_history_item"> | ||
<p><t t-esc="msg.author_id.name or 'unknown'" /> commented on <span |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
t-esc
is soft deprecated, could we switch to t-out
here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to be addressed
76023ba
to
7f492cd
Compare
Followers of a discussion in the chatter of Odoo can be informed by email of a new message being created. This module adds in that email the history of the chatter discussion to help the recipient with more context.
Currently translated at 100.0% (7 of 7 strings) Translation: social-14.0/social-14.0-mail_notification_with_history Translate-URL: https://translation.odoo-community.org/projects/social-14-0/social-14-0-mail_notification_with_history/es/
7f492cd
to
e3cb4ad
Compare
This PR has the |
/ocabot migration mail_notification_with_history |
This PR looks fantastic, let's merge it! |
Congratulations, your PR was merged at c2442a9. Thanks a lot for contributing to OCA. ❤️ |
Note
template
message_notification_email
was moved todata/mail_templates.xml
in odoo/odoo@78c68f4Later splitted for better isolate notification layouts in odoo/odoo@a480f1f
This change
Result