Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0] [MIG] mail_activity_reply_creator: Migration to 16.0 #1504

Merged
merged 7 commits into from
Nov 20, 2024

Conversation

renda-dev
Copy link
Contributor

Migration of mail_activity_reply_creator to v16

@renda-dev renda-dev changed the title [MIG] mail_activity_reply_creator: Migration to 16.0 [16.0] [MIG] mail_activity_reply_creator: Migration to 16.0 Nov 18, 2024
@renda-dev renda-dev force-pushed the 16.0-mig-mail_activity_reply_creator branch 2 times, most recently from 9ca4d3b to 656f399 Compare November 20, 2024 10:33
@aleuffre
Copy link

I think some translation commits got lost while squashing administrative commits

https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests

@renda-dev renda-dev force-pushed the 16.0-mig-mail_activity_reply_creator branch from 656f399 to efa3b79 Compare November 20, 2024 10:45
@renda-dev
Copy link
Contributor Author

I think some translation commits got lost while squashing administrative commits

Thanks for letting me notice!

  • Re-added translation commits
  • mail_activity_reply_creator breaks tests for mail_composer_cc_bcc_account, so i splitted them.

Copy link

@aleuffre aleuffre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review, LGTM

@renda-dev
Copy link
Contributor Author

Hello @OCA/social-maintainers,
could anyone take a look at this when they have time? Thanks!

Copy link
Member

@etobella etobella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technical review

@etobella
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-1504-by-etobella-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 9701164 into OCA:16.0 Nov 20, 2024
9 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at de070aa. Thanks a lot for contributing to OCA. ❤️

@PicchiSeba PicchiSeba deleted the 16.0-mig-mail_activity_reply_creator branch November 20, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants