-
-
Notifications
You must be signed in to change notification settings - Fork 674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[14.0] [MIG] stock_picking_return_lot #1634
[14.0] [MIG] stock_picking_return_lot #1634
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional ok
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code LGTM
@renda-dev You should preserve commit history. See : https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-14.0 |
/ocabot migration stock_picking_return_lot |
@renda-dev @GSLabIt @francesco-ooops A little approval there: #1635 It fixes current errors in main 14.0 branch. |
6dee4b4
to
9cdf84a
Compare
Done, let me know if it looks right :) |
ba00aa0
to
a2fccde
Compare
a2fccde
to
687ef89
Compare
@rousseldenis could u please double check and merge? Thx |
@pedrobaeza can we ask for merge? thanks! |
@renda-dev I would say commit history in 12.0 looks like : Why having removed everything ? |
@rousseldenis isn't that what's requested in the migration guide, specifically:
? |
This is not mandatory. But ok. |
/ocabot merge patch |
This PR looks fantastic, let's merge it! |
What a great day to merge this nice PR. Let's do it! |
@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-1634-by-pedrobaeza-bump-nobump. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
Congratulations, your PR was merged at a783e0b. Thanks a lot for contributing to OCA. ❤️ |
Migration of
stock_picking_return_lot
from version 12.0 to version 14.0