From d5640863b1365f0e1251b467b30ad3b8c0924d84 Mon Sep 17 00:00:00 2001 From: sbejaoui Date: Tue, 29 Oct 2024 19:58:39 +0100 Subject: [PATCH] [ADD] stock_available_to_promise_release_restrict_lot --- ..._available_to_promise_release_restrict_lot | 1 + .../setup.py | 6 + stock_available_to_promise_release/README.rst | 1 + .../models/stock_move.py | 46 +- .../readme/CONTRIBUTORS.rst | 1 + .../static/description/index.html | 12 +- .../README.rst | 111 +++++ .../__init__.py | 1 + .../__manifest__.py | 13 + .../models/__init__.py | 1 + .../models/stock_move.py | 81 ++++ .../readme/CONTEXT.md | 14 + .../readme/CONTRIBUTORS.md | 1 + .../readme/DESCRIPTION.md | 8 + .../static/description/icon.png | Bin 0 -> 9455 bytes .../static/description/index.html | 454 ++++++++++++++++++ .../tests/__init__.py | 1 + ...ailable_to_promise_release_restrict_lot.py | 203 ++++++++ 18 files changed, 925 insertions(+), 30 deletions(-) create mode 120000 setup/stock_available_to_promise_release_restrict_lot/odoo/addons/stock_available_to_promise_release_restrict_lot create mode 100644 setup/stock_available_to_promise_release_restrict_lot/setup.py create mode 100644 stock_available_to_promise_release_restrict_lot/README.rst create mode 100644 stock_available_to_promise_release_restrict_lot/__init__.py create mode 100644 stock_available_to_promise_release_restrict_lot/__manifest__.py create mode 100644 stock_available_to_promise_release_restrict_lot/models/__init__.py create mode 100644 stock_available_to_promise_release_restrict_lot/models/stock_move.py create mode 100644 stock_available_to_promise_release_restrict_lot/readme/CONTEXT.md create mode 100644 stock_available_to_promise_release_restrict_lot/readme/CONTRIBUTORS.md create mode 100644 stock_available_to_promise_release_restrict_lot/readme/DESCRIPTION.md create mode 100644 stock_available_to_promise_release_restrict_lot/static/description/icon.png create mode 100644 stock_available_to_promise_release_restrict_lot/static/description/index.html create mode 100644 stock_available_to_promise_release_restrict_lot/tests/__init__.py create mode 100644 stock_available_to_promise_release_restrict_lot/tests/test_stock_available_to_promise_release_restrict_lot.py diff --git a/setup/stock_available_to_promise_release_restrict_lot/odoo/addons/stock_available_to_promise_release_restrict_lot b/setup/stock_available_to_promise_release_restrict_lot/odoo/addons/stock_available_to_promise_release_restrict_lot new file mode 120000 index 0000000000..e9809af3a3 --- /dev/null +++ b/setup/stock_available_to_promise_release_restrict_lot/odoo/addons/stock_available_to_promise_release_restrict_lot @@ -0,0 +1 @@ +../../../../stock_available_to_promise_release_restrict_lot \ No newline at end of file diff --git a/setup/stock_available_to_promise_release_restrict_lot/setup.py b/setup/stock_available_to_promise_release_restrict_lot/setup.py new file mode 100644 index 0000000000..28c57bb640 --- /dev/null +++ b/setup/stock_available_to_promise_release_restrict_lot/setup.py @@ -0,0 +1,6 @@ +import setuptools + +setuptools.setup( + setup_requires=['setuptools-odoo'], + odoo_addon=True, +) diff --git a/stock_available_to_promise_release/README.rst b/stock_available_to_promise_release/README.rst index 18da72d2c0..471ddaacd7 100644 --- a/stock_available_to_promise_release/README.rst +++ b/stock_available_to_promise_release/README.rst @@ -139,6 +139,7 @@ Contributors * Dung Tran * Laurent Mignon * Michael Tietz (MT Software) +* Souheil Bejaoui Other credits ~~~~~~~~~~~~~ diff --git a/stock_available_to_promise_release/models/stock_move.py b/stock_available_to_promise_release/models/stock_move.py index d59d90eb59..69b467a1ef 100644 --- a/stock_available_to_promise_release/models/stock_move.py +++ b/stock_available_to_promise_release/models/stock_move.py @@ -401,31 +401,31 @@ def _get_ordered_available_to_promise_by_warehouse(self, warehouse): item["product_id"][0]: item["quantity"] for item in location_quants } for move in self: - product_uom = move.product_id.uom_id - previous_promised_qty = move.previous_promised_qty - - rounding = product_uom.rounding - available_qty = float_round( - quants_available.get(move.product_id.id, 0.0), - precision_rounding=rounding, - ) - - real_promised = available_qty - previous_promised_qty - uom_promised = product_uom._compute_quantity( - real_promised, - move.product_uom, - rounding_method="HALF-UP", - ) - res[move] = { - "ordered_available_to_promise_uom_qty": max( - min(uom_promised, move.product_uom_qty), 0.0 - ), - "ordered_available_to_promise_qty": max( - min(real_promised, move.product_qty), 0.0 - ), - } + available_qty = quants_available.get(move.product_id.id, 0.0) + res[move] = move._get_ordered_available_to_promise_qty(available_qty) return res + def _get_ordered_available_to_promise_qty(self, available_qty): + self.ensure_one() + product_uom = self.product_id.uom_id + rounding = product_uom.rounding + previous_promised_qty = self.previous_promised_qty + available_qty = float_round(available_qty, precision_rounding=rounding) + real_promised = available_qty - previous_promised_qty + uom_promised = product_uom._compute_quantity( + real_promised, + self.product_uom, + rounding_method="HALF-UP", + ) + return { + "ordered_available_to_promise_uom_qty": max( + min(uom_promised, self.product_uom_qty), 0.0 + ), + "ordered_available_to_promise_qty": max( + min(real_promised, self.product_qty), 0.0 + ), + } + def _get_ordered_available_to_promise(self): res = {} moves_by_warehouse = self._group_by_warehouse() diff --git a/stock_available_to_promise_release/readme/CONTRIBUTORS.rst b/stock_available_to_promise_release/readme/CONTRIBUTORS.rst index 137e8a2d97..e52e3b983c 100644 --- a/stock_available_to_promise_release/readme/CONTRIBUTORS.rst +++ b/stock_available_to_promise_release/readme/CONTRIBUTORS.rst @@ -4,3 +4,4 @@ * Dung Tran * Laurent Mignon * Michael Tietz (MT Software) +* Souheil Bejaoui diff --git a/stock_available_to_promise_release/static/description/index.html b/stock_available_to_promise_release/static/description/index.html index 40492af1d4..647c2b8d03 100644 --- a/stock_available_to_promise_release/static/description/index.html +++ b/stock_available_to_promise_release/static/description/index.html @@ -8,11 +8,10 @@ /* :Author: David Goodger (goodger@python.org) -:Id: $Id: html4css1.css 9511 2024-01-13 09:50:07Z milde $ +:Id: $Id: html4css1.css 8954 2022-01-20 10:10:25Z milde $ :Copyright: This stylesheet has been placed in the public domain. Default cascading style sheet for the HTML output of Docutils. -Despite the name, some widely supported CSS2 features are used. See https://docutils.sourceforge.io/docs/howto/html-stylesheets.html for how to customize this style sheet. @@ -275,7 +274,7 @@ margin-left: 2em ; margin-right: 2em } -pre.code .ln { color: gray; } /* line numbers */ +pre.code .ln { color: grey; } /* line numbers */ pre.code, code { background-color: #eeeeee } pre.code .comment, code .comment { color: #5C6576 } pre.code .keyword, code .keyword { color: #3B0D06; font-weight: bold } @@ -301,7 +300,7 @@ span.pre { white-space: pre } -span.problematic, pre.problematic { +span.problematic { color: red } span.section-subtitle { @@ -477,6 +476,7 @@

Contributors

  • Dung Tran <dungtd@trobz.com>
  • Laurent Mignon <laurent.mignon@acsone.eu>
  • Michael Tietz (MT Software) <mtietz@mt-software.de>
    • +
  • Souheil Bejaoui <soueil.bejaoui@acsone.eu>
    • @@ -489,9 +489,7 @@

    Other credits

    Maintainers

    This module is maintained by the OCA.

    - -Odoo Community Association - +Odoo Community Association

    OCA, or the Odoo Community Association, is a nonprofit organization whose mission is to support the collaborative development of Odoo features and promote its widespread use.

    diff --git a/stock_available_to_promise_release_restrict_lot/README.rst b/stock_available_to_promise_release_restrict_lot/README.rst new file mode 100644 index 0000000000..2c8172f820 --- /dev/null +++ b/stock_available_to_promise_release_restrict_lot/README.rst @@ -0,0 +1,111 @@ +=============================================== +Stock Available To Promise Release Restrict Lot +=============================================== + +.. + !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! + !! This file is generated by oca-gen-addon-readme !! + !! changes will be overwritten. !! + !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! + !! source digest: sha256:62462fd44997edc1156593f1be5e631c8944a601041a92e568a58abe559ffbd8 + !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! + +.. |badge1| image:: https://img.shields.io/badge/maturity-Beta-yellow.png + :target: https://odoo-community.org/page/development-status + :alt: Beta +.. |badge2| image:: https://img.shields.io/badge/licence-AGPL--3-blue.png + :target: http://www.gnu.org/licenses/agpl-3.0-standalone.html + :alt: License: AGPL-3 +.. |badge3| image:: https://img.shields.io/badge/github-OCA%2Fwms-lightgray.png?logo=github + :target: https://github.com/OCA/wms/tree/16.0/stock_available_to_promise_release_restrict_lot + :alt: OCA/wms +.. |badge4| image:: https://img.shields.io/badge/weblate-Translate%20me-F47D42.png + :target: https://translation.odoo-community.org/projects/wms-16-0/wms-16-0-stock_available_to_promise_release_restrict_lot + :alt: Translate me on Weblate +.. |badge5| image:: https://img.shields.io/badge/runboat-Try%20me-875A7B.png + :target: https://runboat.odoo-community.org/builds?repo=OCA/wms&target_branch=16.0 + :alt: Try me on Runboat + +|badge1| |badge2| |badge3| |badge4| |badge5| + +This module acts as an integration layer between +``stock_available_to_promise_release`` and ``stock_restrict_lot``, +enabling advanced stock allocation based on both available-to-promise +quantities and lot restrictions. + +By combining available-to-promise logic with lot restriction +functionality, this module enhances stock move allocation by: + +- Allowing stock moves to respect both priority and specific lot + allocations. +- Ensuring that available quantities are promised according to move + priority, but only when the lot matches the restriction. + +**Table of contents** + +.. contents:: + :local: + +Use Cases / Context +=================== + +When both ``stock_available_to_promise_release`` and +``stock_restrict_lot`` modules are installed, the calculation of +quantities available to promise doesn't properly account for lot +restrictions. This results in a priority conflict, where higher-priority +moves that are restricted to a specific lot receive available quantities +from any lot, bypassing their lot restriction. + +The issue manifests as follows: + +- A move with a higher priority, restricted to a specific lot, is + promised the available quantity regardless of lot constraints. +- If the restricted lot is allocated to another move with lower + priority, the lower-priority move can not be promised its designated + lot. + +In effect, lot-restricted moves cannot accurately reserve quantities +based on both priority and specific lot requirements. This can lead to +stock release issues, where low-priority moves fail to secure stock from +their restricted lots due to incorrect available to promise calculations +in higher-priority moves. + +Bug Tracker +=========== + +Bugs are tracked on `GitHub Issues `_. +In case of trouble, please check there if your issue has already been reported. +If you spotted it first, help us to smash it by providing a detailed and welcomed +`feedback `_. + +Do not contact contributors directly about support or help with technical issues. + +Credits +======= + +Authors +------- + +* ACSONE SA/NV + +Contributors +------------ + +- Souheil Bejaoui soueil.bejaoui@acsone.eu + +Maintainers +----------- + +This module is maintained by the OCA. + +.. image:: https://odoo-community.org/logo.png + :alt: Odoo Community Association + :target: https://odoo-community.org + +OCA, or the Odoo Community Association, is a nonprofit organization whose +mission is to support the collaborative development of Odoo features and +promote its widespread use. + +This module is part of the `OCA/wms `_ project on GitHub. + +You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute. diff --git a/stock_available_to_promise_release_restrict_lot/__init__.py b/stock_available_to_promise_release_restrict_lot/__init__.py new file mode 100644 index 0000000000..0650744f6b --- /dev/null +++ b/stock_available_to_promise_release_restrict_lot/__init__.py @@ -0,0 +1 @@ +from . import models diff --git a/stock_available_to_promise_release_restrict_lot/__manifest__.py b/stock_available_to_promise_release_restrict_lot/__manifest__.py new file mode 100644 index 0000000000..38bfd30924 --- /dev/null +++ b/stock_available_to_promise_release_restrict_lot/__manifest__.py @@ -0,0 +1,13 @@ +# Copyright 2024 ACSONE SA/NV +# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl). + +{ + "name": "Stock Available To Promise Release Restrict Lot", + "version": "16.0.1.0.0", + "license": "AGPL-3", + "author": "ACSONE SA/NV,Odoo Community Association (OCA)", + "website": "https://github.com/OCA/wms", + "depends": ["stock_available_to_promise_release", "stock_restrict_lot"], + "data": [], + "demo": [], +} diff --git a/stock_available_to_promise_release_restrict_lot/models/__init__.py b/stock_available_to_promise_release_restrict_lot/models/__init__.py new file mode 100644 index 0000000000..6bda2d2428 --- /dev/null +++ b/stock_available_to_promise_release_restrict_lot/models/__init__.py @@ -0,0 +1 @@ +from . import stock_move diff --git a/stock_available_to_promise_release_restrict_lot/models/stock_move.py b/stock_available_to_promise_release_restrict_lot/models/stock_move.py new file mode 100644 index 0000000000..9291d6c9ab --- /dev/null +++ b/stock_available_to_promise_release_restrict_lot/models/stock_move.py @@ -0,0 +1,81 @@ +# Copyright 2024 ACSONE SA/NV +# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl). + +from odoo import models +from odoo.osv.expression import AND + + +class StockMove(models.Model): + + _inherit = "stock.move" + + def _previous_promised_qty_sql_lateral_where(self, warehouse): + sql, params = super()._previous_promised_qty_sql_lateral_where(warehouse) + sql += "AND m.restrict_lot_id is null" + return sql, params + + def _get_previous_restricted_lot_moves_domain(self): + return [ + "&", + ("restrict_lot_id", "=", self.restrict_lot_id.id), + "&", + ("state", "not in", ["done", "cancel"]), + "&", + ("id", "!=", self.id), + "|", + ("priority", ">", self.priority), + "|", + "&", + ("priority", "=", self.priority), + ("date_priority", "<", self.date_priority), + "&", + ("priority", "=", self.priority), + "&", + ("date_priority", "=", self.date_priority), + ("id", "<", self.id), + ] + + def _get_previous_restricted_lot_moves(self): + self.ensure_one() + if not self.restrict_lot_id: + return self.browse() + return self.search(self._get_previous_restricted_lot_moves_domain()) + + def _get_previous_promised_qties(self): + restrict_lot_moves = self.filtered("restrict_lot_id") + no_restrict_lot_moves = self - restrict_lot_moves + res = super(StockMove, no_restrict_lot_moves)._get_previous_promised_qties() + for move in restrict_lot_moves: + previous_moves = self._get_previous_restricted_lot_moves() + res[move.id] = ( + sum(previous_moves.mapped("product_uom_qty")) if previous_moves else 0 + ) + return res + + def _get_ordered_available_to_promise_by_warehouse(self, warehouse): + restrict_lot_moves = self.filtered("restrict_lot_id") + no_restrict_lot_moves = self - restrict_lot_moves + res = super( + StockMove, no_restrict_lot_moves + )._get_ordered_available_to_promise_by_warehouse(warehouse) + if not warehouse: + for move in restrict_lot_moves: + res[move] = { + "ordered_available_to_promise_uom_qty": 0, + "ordered_available_to_promise_qty": 0, + } + return res + location_domain = warehouse.view_location_id._get_available_to_promise_domain() + domain_quant = AND( + [[("lot_id", "in", self.restrict_lot_id.ids)], location_domain] + ) + location_quants = self.env["stock.quant"].read_group( + domain_quant, ["lot_id", "quantity"], ["lot_id"], orderby="id" + ) + quants_available = { + item["lot_id"][0]: item["quantity"] for item in location_quants + } + for move in restrict_lot_moves: + available_qty = quants_available.get(move.restrict_lot_id.id, 0.0) + res[move] = move._get_ordered_available_to_promise_qty(available_qty) + return res diff --git a/stock_available_to_promise_release_restrict_lot/readme/CONTEXT.md b/stock_available_to_promise_release_restrict_lot/readme/CONTEXT.md new file mode 100644 index 0000000000..47b3b6bdbf --- /dev/null +++ b/stock_available_to_promise_release_restrict_lot/readme/CONTEXT.md @@ -0,0 +1,14 @@ +When both `stock_available_to_promise_release` and `stock_restrict_lot` modules +are installed, the calculation of quantities available to promise doesn't +properly account for lot restrictions. This results in a priority conflict, +where higher-priority moves that are restricted to a specific lot receive +available quantities from any lot, bypassing their lot restriction. + +The issue manifests as follows: +- A move with a higher priority, restricted to a specific lot, is promised the available quantity regardless of lot constraints. +- If the restricted lot is allocated to another move with lower priority, the lower-priority move can not be promised its designated lot. + +In effect, lot-restricted moves cannot accurately reserve quantities based on +both priority and specific lot requirements. +This can lead to stock release issues, where low-priority moves fail to secure +stock from their restricted lots due to incorrect available to promise calculations in higher-priority moves. \ No newline at end of file diff --git a/stock_available_to_promise_release_restrict_lot/readme/CONTRIBUTORS.md b/stock_available_to_promise_release_restrict_lot/readme/CONTRIBUTORS.md new file mode 100644 index 0000000000..2c84ca6948 --- /dev/null +++ b/stock_available_to_promise_release_restrict_lot/readme/CONTRIBUTORS.md @@ -0,0 +1 @@ +* Souheil Bejaoui diff --git a/stock_available_to_promise_release_restrict_lot/readme/DESCRIPTION.md b/stock_available_to_promise_release_restrict_lot/readme/DESCRIPTION.md new file mode 100644 index 0000000000..d0785fbf93 --- /dev/null +++ b/stock_available_to_promise_release_restrict_lot/readme/DESCRIPTION.md @@ -0,0 +1,8 @@ +This module acts as an integration layer between `stock_available_to_promise_release` +and `stock_restrict_lot`, enabling advanced stock allocation based on both +available-to-promise quantities and lot restrictions. + +By combining available-to-promise logic with lot restriction functionality, +this module enhances stock move allocation by: +- Allowing stock moves to respect both priority and specific lot allocations. +- Ensuring that available quantities are promised according to move priority, but only when the lot matches the restriction. diff --git a/stock_available_to_promise_release_restrict_lot/static/description/icon.png b/stock_available_to_promise_release_restrict_lot/static/description/icon.png new file mode 100644 index 0000000000000000000000000000000000000000..3a0328b516c4980e8e44cdb63fd945757ddd132d GIT binary patch literal 9455 zcmW++2RxMjAAjx~&dlBk9S+%}OXg)AGE&Cb*&}d0jUxM@u(PQx^-s)697TX`ehR4?GS^qbkof1cslKgkU)h65qZ9Oc=ml_0temigYLJfnz{IDzUf>bGs4N!v3=Z3jMq&A#7%rM5eQ#dc?k~! zVpnB`o+K7|Al`Q_U;eD$B zfJtP*jH`siUq~{KE)`jP2|#TUEFGRryE2`i0**z#*^6~AI|YzIWy$Cu#CSLW3q=GA z6`?GZymC;dCPk~rBS%eCb`5OLr;RUZ;D`}um=H)BfVIq%7VhiMr)_#G0N#zrNH|__ zc+blN2UAB0=617@>_u;MPHN;P;N#YoE=)R#i$k_`UAA>WWCcEVMh~L_ zj--gtp&|K1#58Yz*AHCTMziU1Jzt_jG0I@qAOHsk$2}yTmVkBp_eHuY$A9)>P6o~I z%aQ?!(GqeQ-Y+b0I(m9pwgi(IIZZzsbMv+9w{PFtd_<_(LA~0H(xz{=FhLB@(1&qHA5EJw1>>=%q2f&^X>IQ{!GJ4e9U z&KlB)z(84HmNgm2hg2C0>WM{E(DdPr+EeU_N@57;PC2&DmGFW_9kP&%?X4}+xWi)( z;)z%wI5>D4a*5XwD)P--sPkoY(a~WBw;E~AW`Yue4kFa^LM3X`8x|}ZUeMnqr}>kH zG%WWW>3ml$Yez?i%)2pbKPI7?5o?hydokgQyZsNEr{a|mLdt;X2TX(#B1j35xPnPW z*bMSSOauW>o;*=kO8ojw91VX!qoOQb)zHJ!odWB}d+*K?#sY_jqPdg{Sm2HdYzdEx zOGVPhVRTGPtv0o}RfVP;Nd(|CB)I;*t&QO8h zFfekr30S!-LHmV_Su-W+rEwYXJ^;6&3|L$mMC8*bQptyOo9;>Qb9Q9`ySe3%V$A*9 zeKEe+b0{#KWGp$F+tga)0RtI)nhMa-K@JS}2krK~n8vJ=Ngm?R!9G<~RyuU0d?nz# z-5EK$o(!F?hmX*2Yt6+coY`6jGbb7tF#6nHA zuKk=GGJ;ZwON1iAfG$E#Y7MnZVmrY|j0eVI(DN_MNFJmyZ|;w4tf@=CCDZ#5N_0K= z$;R~bbk?}TpfDjfB&aiQ$VA}s?P}xPERJG{kxk5~R`iRS(SK5d+Xs9swCozZISbnS zk!)I0>t=A<-^z(cmSFz3=jZ23u13X><0b)P)^1T_))Kr`e!-pb#q&J*Q`p+B6la%C zuVl&0duN<;uOsB3%T9Fp8t{ED108<+W(nOZd?gDnfNBC3>M8WE61$So|P zVvqH0SNtDTcsUdzaMDpT=Ty0pDHHNL@Z0w$Y`XO z2M-_r1S+GaH%pz#Uy0*w$Vdl=X=rQXEzO}d6J^R6zjM1u&c9vYLvLp?W7w(?np9x1 zE_0JSAJCPB%i7p*Wvg)pn5T`8k3-uR?*NT|J`eS#_#54p>!p(mLDvmc-3o0mX*mp_ zN*AeS<>#^-{S%W<*mz^!X$w_2dHWpcJ6^j64qFBft-o}o_Vx80o0>}Du;>kLts;$8 zC`7q$QI(dKYG`Wa8#wl@V4jVWBRGQ@1dr-hstpQL)Tl+aqVpGpbSfN>5i&QMXfiZ> zaA?T1VGe?rpQ@;+pkrVdd{klI&jVS@I5_iz!=UMpTsa~mBga?1r}aRBm1WS;TT*s0f0lY=JBl66Upy)-k4J}lh=P^8(SXk~0xW=T9v*B|gzIhN z>qsO7dFd~mgxAy4V?&)=5ieYq?zi?ZEoj)&2o)RLy=@hbCRcfT5jigwtQGE{L*8<@Yd{zg;CsL5mvzfDY}P-wos_6PfprFVaeqNE%h zKZhLtcQld;ZD+>=nqN~>GvROfueSzJD&BE*}XfU|H&(FssBqY=hPCt`d zH?@s2>I(|;fcW&YM6#V#!kUIP8$Nkdh0A(bEVj``-AAyYgwY~jB zT|I7Bf@%;7aL7Wf4dZ%VqF$eiaC38OV6oy3Z#TER2G+fOCd9Iaoy6aLYbPTN{XRPz z;U!V|vBf%H!}52L2gH_+j;`bTcQRXB+y9onc^wLm5wi3-Be}U>k_u>2Eg$=k!(l@I zcCg+flakT2Nej3i0yn+g+}%NYb?ta;R?(g5SnwsQ49U8Wng8d|{B+lyRcEDvR3+`O{zfmrmvFrL6acVP%yG98X zo&+VBg@px@i)%o?dG(`T;n*$S5*rnyiR#=wW}}GsAcfyQpE|>a{=$Hjg=-*_K;UtD z#z-)AXwSRY?OPefw^iI+ z)AXz#PfEjlwTes|_{sB?4(O@fg0AJ^g8gP}ex9Ucf*@_^J(s_5jJV}c)s$`Myn|Kd z$6>}#q^n{4vN@+Os$m7KV+`}c%4)4pv@06af4-x5#wj!KKb%caK{A&Y#Rfs z-po?Dcb1({W=6FKIUirH&(yg=*6aLCekcKwyfK^JN5{wcA3nhO(o}SK#!CINhI`-I z1)6&n7O&ZmyFMuNwvEic#IiOAwNkR=u5it{B9n2sAJV5pNhar=j5`*N!Na;c7g!l$ z3aYBqUkqqTJ=Re-;)s!EOeij=7SQZ3Hq}ZRds%IM*PtM$wV z@;rlc*NRK7i3y5BETSKuumEN`Xu_8GP1Ri=OKQ$@I^ko8>H6)4rjiG5{VBM>B|%`&&s^)jS|-_95&yc=GqjNo{zFkw%%HHhS~e=s zD#sfS+-?*t|J!+ozP6KvtOl!R)@@-z24}`9{QaVLD^9VCSR2b`b!KC#o;Ki<+wXB6 zx3&O0LOWcg4&rv4QG0)4yb}7BFSEg~=IR5#ZRj8kg}dS7_V&^%#Do==#`u zpy6{ox?jWuR(;pg+f@mT>#HGWHAJRRDDDv~@(IDw&R>9643kK#HN`!1vBJHnC+RM&yIh8{gG2q zA%e*U3|N0XSRa~oX-3EAneep)@{h2vvd3Xvy$7og(sayr@95+e6~Xvi1tUqnIxoIH zVWo*OwYElb#uyW{Imam6f2rGbjR!Y3`#gPqkv57dB6K^wRGxc9B(t|aYDGS=m$&S!NmCtrMMaUg(c zc2qC=2Z`EEFMW-me5B)24AqF*bV5Dr-M5ig(l-WPS%CgaPzs6p_gnCIvTJ=Y<6!gT zVt@AfYCzjjsMEGi=rDQHo0yc;HqoRNnNFeWZgcm?f;cp(6CNylj36DoL(?TS7eU#+ z7&mfr#y))+CJOXQKUMZ7QIdS9@#-}7y2K1{8)cCt0~-X0O!O?Qx#E4Og+;A2SjalQ zs7r?qn0H044=sDN$SRG$arw~n=+T_DNdSrarmu)V6@|?1-ZB#hRn`uilTGPJ@fqEy zGt(f0B+^JDP&f=r{#Y_wi#AVDf-y!RIXU^0jXsFpf>=Ji*TeqSY!H~AMbJdCGLhC) zn7Rx+sXw6uYj;WRYrLd^5IZq@6JI1C^YkgnedZEYy<&4(z%Q$5yv#Boo{AH8n$a zhb4Y3PWdr269&?V%uI$xMcUrMzl=;w<_nm*qr=c3Rl@i5wWB;e-`t7D&c-mcQl7x! zZWB`UGcw=Y2=}~wzrfLx=uet<;m3~=8I~ZRuzvMQUQdr+yTV|ATf1Uuomr__nDf=X zZ3WYJtHp_ri(}SQAPjv+Y+0=fH4krOP@S&=zZ-t1jW1o@}z;xk8 z(Nz1co&El^HK^NrhVHa-_;&88vTU>_J33=%{if;BEY*J#1n59=07jrGQ#IP>@u#3A z;!q+E1Rj3ZJ+!4bq9F8PXJ@yMgZL;>&gYA0%_Kbi8?S=XGM~dnQZQ!yBSgcZhY96H zrWnU;k)qy`rX&&xlDyA%(a1Hhi5CWkmg(`Gb%m(HKi-7Z!LKGRP_B8@`7&hdDy5n= z`OIxqxiVfX@OX1p(mQu>0Ai*v_cTMiw4qRt3~NBvr9oBy0)r>w3p~V0SCm=An6@3n)>@z!|o-$HvDK z|3D2ZMJkLE5loMKl6R^ez@Zz%S$&mbeoqH5`Bb){Ei21q&VP)hWS2tjShfFtGE+$z zzCR$P#uktu+#!w)cX!lWN1XU%K-r=s{|j?)Akf@q#3b#{6cZCuJ~gCxuMXRmI$nGtnH+-h z+GEi!*X=AP<|fG`1>MBdTb?28JYc=fGvAi2I<$B(rs$;eoJCyR6_bc~p!XR@O-+sD z=eH`-ye})I5ic1eL~TDmtfJ|8`0VJ*Yr=hNCd)G1p2MMz4C3^Mj?7;!w|Ly%JqmuW zlIEW^Ft%z?*|fpXda>Jr^1noFZEwFgVV%|*XhH@acv8rdGxeEX{M$(vG{Zw+x(ei@ zmfXb22}8-?Fi`vo-YVrTH*C?a8%M=Hv9MqVH7H^J$KsD?>!SFZ;ZsvnHr_gn=7acz z#W?0eCdVhVMWN12VV^$>WlQ?f;P^{(&pYTops|btm6aj>_Uz+hqpGwB)vWp0Cf5y< zft8-je~nn?W11plq}N)4A{l8I7$!ks_x$PXW-2XaRFswX_BnF{R#6YIwMhAgd5F9X zGmwdadS6(a^fjHtXg8=l?Rc0Sm%hk6E9!5cLVloEy4eh(=FwgP`)~I^5~pBEWo+F6 zSf2ncyMurJN91#cJTy_u8Y}@%!bq1RkGC~-bV@SXRd4F{R-*V`bS+6;W5vZ(&+I<9$;-V|eNfLa5n-6% z2(}&uGRF;p92eS*sE*oR$@pexaqr*meB)VhmIg@h{uzkk$9~qh#cHhw#>O%)b@+(| z^IQgqzuj~Sk(J;swEM-3TrJAPCq9k^^^`q{IItKBRXYe}e0Tdr=Huf7da3$l4PdpwWDop%^}n;dD#K4s#DYA8SHZ z&1!riV4W4R7R#C))JH1~axJ)RYnM$$lIR%6fIVA@zV{XVyx}C+a-Dt8Y9M)^KU0+H zR4IUb2CJ{Hg>CuaXtD50jB(_Tcx=Z$^WYu2u5kubqmwp%drJ6 z?Fo40g!Qd<-l=TQxqHEOuPX0;^z7iX?Ke^a%XT<13TA^5`4Xcw6D@Ur&VT&CUe0d} z1GjOVF1^L@>O)l@?bD~$wzgf(nxX1OGD8fEV?TdJcZc2KoUe|oP1#=$$7ee|xbY)A zDZq+cuTpc(fFdj^=!;{k03C69lMQ(|>uhRfRu%+!k&YOi-3|1QKB z z?n?eq1XP>p-IM$Z^C;2L3itnbJZAip*Zo0aw2bs8@(s^~*8T9go!%dHcAz2lM;`yp zD=7&xjFV$S&5uDaiScyD?B-i1ze`+CoRtz`Wn+Zl&#s4&}MO{@N!ufrzjG$B79)Y2d3tBk&)TxUTw@QS0TEL_?njX|@vq?Uz(nBFK5Pq7*xj#u*R&i|?7+6# z+|r_n#SW&LXhtheZdah{ZVoqwyT{D>MC3nkFF#N)xLi{p7J1jXlmVeb;cP5?e(=f# zuT7fvjSbjS781v?7{)-X3*?>tq?)Yd)~|1{BDS(pqC zC}~H#WXlkUW*H5CDOo<)#x7%RY)A;ShGhI5s*#cRDA8YgqG(HeKDx+#(ZQ?386dv! zlXCO)w91~Vw4AmOcATuV653fa9R$fyK8ul%rG z-wfS zihugoZyr38Im?Zuh6@RcF~t1anQu7>#lPpb#}4cOA!EM11`%f*07RqOVkmX{p~KJ9 z^zP;K#|)$`^Rb{rnHGH{~>1(fawV0*Z#)}M`m8-?ZJV<+e}s9wE# z)l&az?w^5{)`S(%MRzxdNqrs1n*-=jS^_jqE*5XDrA0+VE`5^*p3CuM<&dZEeCjoz zR;uu_H9ZPZV|fQq`Cyw4nscrVwi!fE6ciMmX$!_hN7uF;jjKG)d2@aC4ropY)8etW=xJvni)8eHi`H$%#zn^WJ5NLc-rqk|u&&4Z6fD_m&JfSI1Bvb?b<*n&sfl0^t z=HnmRl`XrFvMKB%9}>PaA`m-fK6a0(8=qPkWS5bb4=v?XcWi&hRY?O5HdulRi4?fN zlsJ*N-0Qw+Yic@s0(2uy%F@ib;GjXt01Fmx5XbRo6+n|pP(&nodMoap^z{~q ziEeaUT@Mxe3vJSfI6?uLND(CNr=#^W<1b}jzW58bIfyWTDle$mmS(|x-0|2UlX+9k zQ^EX7Nw}?EzVoBfT(-LT|=9N@^hcn-_p&sqG z&*oVs2JSU+N4ZD`FhCAWaS;>|wH2G*Id|?pa#@>tyxX`+4HyIArWDvVrX)2WAOQff z0qyHu&-S@i^MS-+j--!pr4fPBj~_8({~e1bfcl0wI1kaoN>mJL6KUPQm5N7lB(ui1 zE-o%kq)&djzWJ}ob<-GfDlkB;F31j-VHKvQUGQ3sp`CwyGJk_i!y^sD0fqC@$9|jO zOqN!r!8-p==F@ZVP=U$qSpY(gQ0)59P1&t@y?5rvg<}E+GB}26NYPp4f2YFQrQtot5mn3wu_qprZ=>Ig-$ zbW26Ws~IgY>}^5w`vTB(G`PTZaDiGBo5o(tp)qli|NeV( z@H_=R8V39rt5J5YB2Ky?4eJJ#b`_iBe2ot~6%7mLt5t8Vwi^Jy7|jWXqa3amOIoRb zOr}WVFP--DsS`1WpN%~)t3R!arKF^Q$e12KEqU36AWwnCBICpH4XCsfnyrHr>$I$4 z!DpKX$OKLWarN7nv@!uIA+~RNO)l$$w}p(;b>mx8pwYvu;dD_unryX_NhT8*Tj>BTrTTL&!?O+%Rv;b?B??gSzdp?6Uug9{ zd@V08Z$BdI?fpoCS$)t4mg4rT8Q_I}h`0d-vYZ^|dOB*Q^S|xqTV*vIg?@fVFSmMpaw0qtTRbx} z({Pg?#{2`sc9)M5N$*N|4;^t$+QP?#mov zGVC@I*lBVrOU-%2y!7%)fAKjpEFsgQc4{amtiHb95KQEwvf<(3T<9-Zm$xIew#P22 zc2Ix|App^>v6(3L_MCU0d3W##AB0M~3D00EWoKZqsJYT(#@w$Y_H7G22M~ApVFTRHMI_3be)Lkn#0F*V8Pq zc}`Cjy$bE;FJ6H7p=0y#R>`}-m4(0F>%@P|?7fx{=R^uFdISRnZ2W_xQhD{YuR3t< z{6yxu=4~JkeA;|(J6_nv#>Nvs&FuLA&PW^he@t(UwFFE8)|a!R{`E`K`i^ZnyE4$k z;(749Ix|oi$c3QbEJ3b~D_kQsPz~fIUKym($a_7dJ?o+40*OLl^{=&oq$<#Q(yyrp z{J-FAniyAw9tPbe&IhQ|a`DqFTVQGQ&Gq3!C2==4x{6EJwiPZ8zub-iXoUtkJiG{} zPaR&}_fn8_z~(=;5lD-aPWD3z8PZS@AaUiomF!G8I}Mf>e~0g#BelA-5#`cj;O5>N Xviia!U7SGha1wx#SCgwmn*{w2TRX*I literal 0 HcmV?d00001 diff --git a/stock_available_to_promise_release_restrict_lot/static/description/index.html b/stock_available_to_promise_release_restrict_lot/static/description/index.html new file mode 100644 index 0000000000..e9fce10c1d --- /dev/null +++ b/stock_available_to_promise_release_restrict_lot/static/description/index.html @@ -0,0 +1,454 @@ + + + + + +Stock Available To Promise Release Restrict Lot + + + +
    +

    Stock Available To Promise Release Restrict Lot

    + + +

    Beta License: AGPL-3 OCA/wms Translate me on Weblate Try me on Runboat

    +

    This module acts as an integration layer between +stock_available_to_promise_release and stock_restrict_lot, +enabling advanced stock allocation based on both available-to-promise +quantities and lot restrictions.

    +

    By combining available-to-promise logic with lot restriction +functionality, this module enhances stock move allocation by:

    +
      +
    • Allowing stock moves to respect both priority and specific lot +allocations.
      • +
    • Ensuring that available quantities are promised according to move +priority, but only when the lot matches the restriction.
      • +
    +

    Table of contents

    + +
    +

    Use Cases / Context

    +

    When both stock_available_to_promise_release and +stock_restrict_lot modules are installed, the calculation of +quantities available to promise doesn’t properly account for lot +restrictions. This results in a priority conflict, where higher-priority +moves that are restricted to a specific lot receive available quantities +from any lot, bypassing their lot restriction.

    +

    The issue manifests as follows:

    +
      +
    • A move with a higher priority, restricted to a specific lot, is +promised the available quantity regardless of lot constraints.
      • +
    • If the restricted lot is allocated to another move with lower +priority, the lower-priority move can not be promised its designated +lot.
      • +
    +

    In effect, lot-restricted moves cannot accurately reserve quantities +based on both priority and specific lot requirements. This can lead to +stock release issues, where low-priority moves fail to secure stock from +their restricted lots due to incorrect available to promise calculations +in higher-priority moves.

    +
    +
    +

    Bug Tracker

    +

    Bugs are tracked on GitHub Issues. +In case of trouble, please check there if your issue has already been reported. +If you spotted it first, help us to smash it by providing a detailed and welcomed +feedback.

    +

    Do not contact contributors directly about support or help with technical issues.

    +
    +
    +

    Credits

    +
    +

    Authors

    +
      +
    • ACSONE SA/NV
      • +
    +
    +
    +

    Contributors

    + +
    +
    +

    Maintainers

    +

    This module is maintained by the OCA.

    +Odoo Community Association +

    OCA, or the Odoo Community Association, is a nonprofit organization whose +mission is to support the collaborative development of Odoo features and +promote its widespread use.

    +

    This module is part of the OCA/wms project on GitHub.

    +

    You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute.

    +
    +
    +
    + + diff --git a/stock_available_to_promise_release_restrict_lot/tests/__init__.py b/stock_available_to_promise_release_restrict_lot/tests/__init__.py new file mode 100644 index 0000000000..5b3bffad4c --- /dev/null +++ b/stock_available_to_promise_release_restrict_lot/tests/__init__.py @@ -0,0 +1 @@ +from . import test_stock_available_to_promise_release_restrict_lot diff --git a/stock_available_to_promise_release_restrict_lot/tests/test_stock_available_to_promise_release_restrict_lot.py b/stock_available_to_promise_release_restrict_lot/tests/test_stock_available_to_promise_release_restrict_lot.py new file mode 100644 index 0000000000..867f2708f1 --- /dev/null +++ b/stock_available_to_promise_release_restrict_lot/tests/test_stock_available_to_promise_release_restrict_lot.py @@ -0,0 +1,203 @@ +# Copyright 2024 ACSONE SA/NV +# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl). + +from odoo import Command +from odoo.tests.common import TransactionCase + + +class TestStockAvailableToPromiseReleaseRestrictLot(TransactionCase): + @classmethod + def setUpClass(cls): + super().setUpClass() + cls.warehouse = cls.env.ref("stock.warehouse0") + cls.location_wh_stock = cls.env.ref("stock.stock_location_stock") + cls.location_customer = cls.env.ref("stock.stock_location_customers") + cls.picking_type = cls.env.ref("stock.picking_type_out") + cls.product = cls.env["product.product"].create( + {"name": "Test Product", "type": "product", "tracking": "lot"} + ) + cls.lot_1 = cls.env["stock.lot"].create( + {"name": "Lot 1", "product_id": cls.product.id} + ) + cls.lot_2 = cls.env["stock.lot"].create( + {"name": "Lot 2", "product_id": cls.product.id} + ) + + # Create stock pickings and moves with different priorities + cls.picking_1 = cls.env["stock.picking"].create( + { + "priority": "1", + "picking_type_id": cls.picking_type.id, + "location_id": cls.location_wh_stock.id, + "location_dest_id": cls.location_customer.id, + "move_ids": [ + Command.create( + { + "name": "move 1", + "warehouse_id": cls.warehouse.id, + "product_id": cls.product.id, + "product_uom_qty": 10, + "product_uom": cls.product.uom_id.id, + "location_id": cls.location_wh_stock.id, + "location_dest_id": cls.location_customer.id, + } + ) + ], + } + ) + cls.move_priority_high = cls.picking_1.move_ids + + cls.picking_2 = cls.env["stock.picking"].create( + { + "priority": "0", + "picking_type_id": cls.picking_type.id, + "location_id": cls.location_wh_stock.id, + "location_dest_id": cls.location_customer.id, + "move_ids": [ + Command.create( + { + "name": "move 2", + "warehouse_id": cls.warehouse.id, + "product_id": cls.product.id, + "product_uom_qty": 10, + "product_uom": cls.product.uom_id.id, + "location_id": cls.location_wh_stock.id, + "location_dest_id": cls.location_customer.id, + } + ) + ], + } + ) + cls.move_priority_low = cls.picking_2.move_ids + + # Confirm and assign the pickings + cls.picking_1.action_confirm() + cls.picking_1.action_assign() + cls.picking_2.action_confirm() + cls.picking_2.action_assign() + + @classmethod + def _update_qty_in_location(cls, location, product, quantity, lot=None): + cls.env["stock.quant"]._update_available_quantity( + product, location, quantity, lot_id=lot + ) + cls.env["product.product"].invalidate_model( + fnames=[ + "qty_available", + "virtual_available", + "incoming_qty", + "outgoing_qty", + ] + ) + + def test_0(self): + """ + Test standard allocation behavior without lot restrictions. + Verifies that moves with higher priority are allocated available quantities + first. + """ + self._update_qty_in_location( + self.location_wh_stock, self.product, 8, self.lot_1 + ) + self.assertEqual(self.move_priority_high.previous_promised_qty, 0) + self.assertEqual(self.move_priority_high.ordered_available_to_promise_qty, 8) + self.assertEqual(self.move_priority_low.previous_promised_qty, 10) + self.assertEqual(self.move_priority_low.ordered_available_to_promise_qty, 0) + + def test_1(self): + """ + Test a high-priority move restricted to a specific lot with no available stock + in that lot. + Verifies that a restricted lot move does not interfere with another move's + allocation. + """ + self.move_priority_high.restrict_lot_id = self.lot_2 + self._update_qty_in_location( + self.location_wh_stock, self.product, 8, self.lot_1 + ) + self.assertEqual(self.move_priority_high.previous_promised_qty, 0) + self.assertEqual(self.move_priority_high.ordered_available_to_promise_qty, 0) + self.assertEqual(self.move_priority_low.previous_promised_qty, 0) + self.assertEqual(self.move_priority_low.ordered_available_to_promise_qty, 8) + + def test_2(self): + """ + Test a low-priority move restricted to a specific lot without interfering with + high-priority allocation. + Verifies that low-priority restrictions don’t reduce available quantities + for high-priority moves. + """ + self.move_priority_low.restrict_lot_id = self.lot_2 + self._update_qty_in_location( + self.location_wh_stock, self.product, 8, self.lot_1 + ) + self.assertEqual(self.move_priority_high.previous_promised_qty, 0) + self.assertEqual(self.move_priority_high.ordered_available_to_promise_qty, 8) + self.assertEqual(self.move_priority_low.previous_promised_qty, 0) + self.assertEqual(self.move_priority_low.ordered_available_to_promise_qty, 0) + + def test_3(self): + """ + Test both moves with lot restrictions and available quantities in each lot. + Verifies that each move is allocated quantities based on its lot restriction. + """ + self.move_priority_high.restrict_lot_id = self.lot_1 + self.move_priority_low.restrict_lot_id = self.lot_2 + self._update_qty_in_location( + self.location_wh_stock, self.product, 8, self.lot_1 + ) + self._update_qty_in_location( + self.location_wh_stock, self.product, 5, self.lot_2 + ) + self.assertEqual(self.move_priority_high.previous_promised_qty, 0) + self.assertEqual(self.move_priority_high.ordered_available_to_promise_qty, 8) + self.assertEqual(self.move_priority_low.previous_promised_qty, 0) + self.assertEqual(self.move_priority_low.ordered_available_to_promise_qty, 5) + + def test_4(self): + """ + Test both moves with lot restrictions to the same lot. + Verifies that each move is allocated quantities based on its lot restriction + respecting the priority. + """ + self.move_priority_high.restrict_lot_id = self.lot_1 + self.move_priority_low.restrict_lot_id = self.lot_1 + self._update_qty_in_location( + self.location_wh_stock, self.product, 15, self.lot_1 + ) + self.assertEqual(self.move_priority_high.previous_promised_qty, 0) + self.assertEqual(self.move_priority_high.ordered_available_to_promise_qty, 10) + self.assertEqual(self.move_priority_low.previous_promised_qty, 10) + self.assertEqual(self.move_priority_low.ordered_available_to_promise_qty, 5) + + def test_5(self): + """ + Test both moves with lot restrictions to the same lot with partial availability. + Verifies that each move is allocated quantities based on its lot restriction + respecting the priority. + """ + self.move_priority_high.restrict_lot_id = self.lot_1 + self.move_priority_low.restrict_lot_id = self.lot_1 + self._update_qty_in_location( + self.location_wh_stock, self.product, 8, self.lot_1 + ) + self.assertEqual(self.move_priority_high.previous_promised_qty, 0) + self.assertEqual(self.move_priority_high.ordered_available_to_promise_qty, 8) + self.assertEqual(self.move_priority_low.previous_promised_qty, 10) + self.assertEqual(self.move_priority_low.ordered_available_to_promise_qty, 0) + + def test_6(self): + """ + Test both moves with lot restrictions to the same lot with no availability. + Verifies that each move is allocated quantities based on its lot restriction + respecting the priority. + """ + self.move_priority_high.restrict_lot_id = self.lot_1 + self.move_priority_low.restrict_lot_id = self.lot_1 + self._update_qty_in_location( + self.location_wh_stock, self.product, 8, self.lot_2 + ) + self.assertEqual(self.move_priority_high.previous_promised_qty, 0) + self.assertEqual(self.move_priority_high.ordered_available_to_promise_qty, 0) + self.assertEqual(self.move_priority_low.previous_promised_qty, 10) + self.assertEqual(self.move_priority_low.ordered_available_to_promise_qty, 0)