Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No more pkg_resources #882

Merged
merged 8 commits into from
Jul 18, 2022
Merged

No more pkg_resources #882

merged 8 commits into from
Jul 18, 2022

Conversation

hnesk
Copy link
Contributor

@hnesk hnesk commented Jun 23, 2022

A first attempt to get rid of pkg_resources as mentioned in #881
I did not measure anything yet, and subjectively not much changed, but we'll see.

kba
kba approved these changes Jun 24, 2022
View reviewed changes
Copy link
Member

@kba kba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even if performance gain is yet to be proven, I see no reason why it would degrade performance either, so LGTM, thanks for following up on the discussion.

ocrd/ocrd/processor/builtin/dummy_processor.py Show resolved Hide resolved
ocrd_utils/ocrd_utils/constants.py Outdated Show resolved Hide resolved
ocrd_utils/ocrd_utils/package_resources.py Show resolved Hide resolved
@kba kba linked an issue Jun 24, 2022 that may be closed by this pull request
Investigate startup speedup by replacing pkg_resources #881
Closed
@hnesk hnesk changed the title WIP: No more pkg_resources No more pkg_resources Jul 18, 2022
@hnesk
Copy link
Contributor Author

hnesk commented Jul 18, 2022 •
edited
Loading

I just removed the WIP label, as the implementation is finished. The performance improvement is neglible, as far as I could interpret the profiler, the startup time is spent mostly on importing modules, and I have no clue how to improve on that.
At least it adapted the code to not use discouraged features any more.

@kba kba merged commit 9a54ef6 into OCR-D:master Jul 18, 2022
This was referenced Jun 1, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kba kba kba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Investigate startup speedup by replacing pkg_resources
2 participants
@hnesk @kba