Adding a condition to cast QueryNode
to SingleResourceCastNode
for Unquoted Type Parameter
#1313
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
This pull request fixes #1304.
Description
This modification adds a condition to cast
QueryNode
toSingleResourceCastNode
.Currently, the QueryNode is only converted to
ConstantNode
and supports thecast
function only with quoted type parameters. For unquoted type parameters, the QueryNode will be of typeSingleResourceCastNode
, resulting in an error becauseSingleResourceCastNode
cannot be cast toConstantNode
.For example, given the following entities:
With this change, we should be able to support these
cast
s with unquoted type parameters:cast(NS.Employee)
: cast Person to Employeecast(Location, NS.WorkAddress)
: cast Location property to NS.WorkAddressChecklist (Uncheck if it is not completed)
Additional work necessary
If documentation update is needed, please add "Docs Needed" label to the issue and provide details about the required document change in the issue.