-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Characterization --> Cohort Incidence --> Incidence Results: Download #302
Labels
Comments
nhall6
added a commit
that referenced
this issue
Sep 9, 2024
All filtered data downloads across all modules should work now, with a button styled the same as the full download. It needs to be a CSV handler though due to the reactable statte
@ericaVoss this is now fixed, and the filtered data download should actually work now for all modules: #332 |
jreps
pushed a commit
that referenced
this issue
Sep 12, 2024
* Fixing #302 and Filtered Data Downloads All filtered data downloads across all modules should work now, with a button styled the same as the full download. It needs to be a CSV handler though due to the reactable statte * Updating the fix Also fixed download buttons in Cohorts module, addressing #298
jreps
added a commit
that referenced
this issue
Sep 19, 2024
* Fixing #301 (#326) Adding alphabetical sort to DB input options * Fixing #296 (#327) Standardizing pickerInput type for database selection where multiple options are possible to improve UX. Also fixed some colDefs in Exposed Cases * Fixing #302 and Filtered Data Downloads (#332) * Fixing #302 and Filtered Data Downloads All filtered data downloads across all modules should work now, with a button styled the same as the full download. It needs to be a CSV handler though due to the reactable statte * Updating the fix Also fixed download buttons in Cohorts module, addressing #298 * Update R_CMD_check_Hades.yaml * Update R_CMD_check_Hades.yaml * Update R_CMD_check_Hades.yaml * fixing R checks fixing R checks * Update cohort-diagnostics-databaseInformation.R (#333) Fixing the issue reported in #162 * fixing issue issue_330 (#334) fixing time plot x-axis * fixing issue 167 (#335) added code to get long database names on multiple lines * Update cohort-diagnostics-timeDistributions.R (#336) adding fix for issue 168 * Update patient-level-prediction-modelSummary.R (#337) --------- Co-authored-by: Nathan Hall <106178605+nhall6@users.noreply.github.com>
jreps
added a commit
that referenced
this issue
Sep 20, 2024
* Fixing Power tables re: #114 Standardizing power table outputs to adhere to OSM standard theme (reactable via resultTableViewer and resultTableServer). Also split the tables into 2 sub-tabs for easier readability * Updating propensity score table Adding conditional formatting of colors to values to aid in interpretation, and also adding an absolute value of beta column. * Updates to propensity score plot Overlaying equipoise statistic onto the plot, and truncating cohort names in legend * Updating covariate balance plot Adding maxSDM to covariate balance plot * Updating captions and systematic error Adding to caption descriptions in figures and overlaying EASE statistic on systematic error plot * Updating systematic error Adding more descriptive filenames for plot downloads * Develop (#340) * Fixing #301 (#326) Adding alphabetical sort to DB input options * Fixing #296 (#327) Standardizing pickerInput type for database selection where multiple options are possible to improve UX. Also fixed some colDefs in Exposed Cases * Fixing #302 and Filtered Data Downloads (#332) * Fixing #302 and Filtered Data Downloads All filtered data downloads across all modules should work now, with a button styled the same as the full download. It needs to be a CSV handler though due to the reactable statte * Updating the fix Also fixed download buttons in Cohorts module, addressing #298 * Update R_CMD_check_Hades.yaml * Update R_CMD_check_Hades.yaml * Update R_CMD_check_Hades.yaml * fixing R checks fixing R checks * Update cohort-diagnostics-databaseInformation.R (#333) Fixing the issue reported in #162 * fixing issue issue_330 (#334) fixing time plot x-axis * fixing issue 167 (#335) added code to get long database names on multiple lines * Update cohort-diagnostics-timeDistributions.R (#336) adding fix for issue 168 * Update patient-level-prediction-modelSummary.R (#337) --------- Co-authored-by: Nathan Hall <106178605+nhall6@users.noreply.github.com> * fixing testing errors --------- Co-authored-by: jreps <jreps@its.jnj.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Generated with OhdsiShinyModules v2.1.5.9000 and ShinyAppBuilder v2.0.1.9000
The Download (Full) downloads a file, but the "details" tab in the file is empty.
The Download (Filtered) doesn't seem to download any file.
I've noticed similar issues across other Download buttons and will continue to document when I catch it.
The text was updated successfully, but these errors were encountered: