Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Improve Multiframe performance - metadata #4551

Open
sedghi opened this issue Nov 27, 2024 · 0 comments
Open

[Feature Request] Improve Multiframe performance - metadata #4551

sedghi opened this issue Nov 27, 2024 · 0 comments

Comments

@sedghi
Copy link
Member

sedghi commented Nov 27, 2024

What feature or change would you like to see made?

We currently parse the metadata by creating the frame metadata from shared and per-frame sequences each time, which is inefficient. We should explore a better approach.

One suggestion by @wayfarer3130 is to use JavaScript objects with inheritance. We can start with an object containing all the instance data we have, then use:

const shared = Object.create(instance, ...sharedFunctionalGroups);
SharedFunctionalGroupsSequence = shared;

For the functional groups, use a hidden value per frame with:

Object.create(shared, ...perFrameValues);

This method will be more memory-efficient and will avoid constantly recreating objects. We can also implement a caching strategy for it.

Why should we prioritize this feature?

Faster multiframe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant