From b89f5cf976f88d9e2f79dc0307345411723d0318 Mon Sep 17 00:00:00 2001
From: Sean Thompson <80723794+iSCJT@users.noreply.github.com>
Date: Wed, 23 Oct 2024 18:48:45 +0100
Subject: [PATCH] fix: escape empty preview variable strings (#3943)

---
 .github/workflows/fly-pr-preview.yml | 46 ++++++++++++++--------------
 1 file changed, 23 insertions(+), 23 deletions(-)

diff --git a/.github/workflows/fly-pr-preview.yml b/.github/workflows/fly-pr-preview.yml
index cc6fda1687..1c6416e047 100644
--- a/.github/workflows/fly-pr-preview.yml
+++ b/.github/workflows/fly-pr-preview.yml
@@ -53,26 +53,26 @@ jobs:
             VITE_SITE_VARIANT=preview
             VITE_PROJECT_VERSION=${{ github.sha }}
             VITE_BRANCH=${{ github.head_ref || github.ref_name }}
-            VITE_CDN_URL=
-            VITE_FIREBASE_API_KEY=
-            VITE_FIREBASE_AUTH_DOMAIN=
-            VITE_FIREBASE_DATABASE_URL=
-            VITE_FIREBASE_MESSAGING_SENDER_ID=
-            VITE_FIREBASE_PROJECT_ID=
-            VITE_FIREBASE_STORAGE_BUCKET=
-            VITE_SENTRY_DSN=${{ secrets.PREVIEW_VITE_SENTRY_DSN }}
-            VITE_GA_TRACKING_ID=${{ secrets.PREVIEW_VITE_GA_TRACKING_ID }}
-            VITE_PATREON_CLIENT_ID=${{ secrets.PREVIEW_VITE_PATREON_CLIENT_ID }}
-            VITE_PLATFORM_THEME=${{ secrets.PREVIEW_VITE_PLATFORM_THEME }}
-            VITE_SUPPORTED_MODULES=${{ secrets.PREVIEW_VITE_SUPPORTED_MODULES }}
-            VITE_API_URL=${{ secrets.PREVIEW_VITE_API_URL }}
-            VITE_ACADEMY_RESOURCE=${{ secrets.PREVIEW_VITE_ACADEMY_RESOURCE }}
-            VITE_PROFILE_GUIDELINES_URL=${{ secrets.PREVIEW_VITE_PROFILE_GUIDELINES_URL }}
-            VITE_SITE_NAME=${{ secrets.PREVIEW_VITE_SITE_NAME }}
-            VITE_THEME=${{ secrets.PREVIEW_VITE_THEME }}
-            VITE_DONATIONS_BODY=${{ secrets.PREVIEW_VITE_DONATIONS_BODY }}
-            VITE_DONATIONS_IFRAME_SRC=${{ secrets.PREVIEW_VITE_DONATIONS_IFRAME_SRC }}
-            VITE_DONATIONS_IMAGE_URL=${{ secrets.PREVIEW_VITE_DONATIONS_IMAGE_URL }}
-            VITE_HOWTOS_HEADING=${{ secrets.PREVIEW_VITE_HOWTOS_HEADING }}
-            VITE_COMMUNITY_PROGRAM_URL=${{ secrets.PREVIEW_VITE_COMMUNITY_PROGRAM_URL }}
-            VITE_QUESTIONS_GUIDELINES_URL=${{ secrets.PREVIEW_VITE_QUESTIONS_GUIDELINES_URL }}
\ No newline at end of file
+            VITE_CDN_URL=""
+            VITE_FIREBASE_API_KEY=""
+            VITE_FIREBASE_AUTH_DOMAIN=""
+            VITE_FIREBASE_DATABASE_URL=""
+            VITE_FIREBASE_MESSAGING_SENDER_ID=""
+            VITE_FIREBASE_PROJECT_ID=""
+            VITE_FIREBASE_STORAGE_BUCKET=""
+            VITE_SENTRY_DSN="${{ secrets.PREVIEW_VITE_SENTRY_DSN }}"
+            VITE_GA_TRACKING_ID="${{ secrets.PREVIEW_VITE_GA_TRACKING_ID }}"
+            VITE_PATREON_CLIENT_ID="${{ secrets.PREVIEW_VITE_PATREON_CLIENT_ID }}"
+            VITE_PLATFORM_THEME="${{ secrets.PREVIEW_VITE_PLATFORM_THEME }}"
+            VITE_SUPPORTED_MODULES="${{ secrets.PREVIEW_VITE_SUPPORTED_MODULES }}"
+            VITE_API_URL="${{ secrets.PREVIEW_VITE_API_URL }}"
+            VITE_ACADEMY_RESOURCE="${{ secrets.PREVIEW_VITE_ACADEMY_RESOURCE }}"
+            VITE_PROFILE_GUIDELINES_URL="${{ secrets.PREVIEW_VITE_PROFILE_GUIDELINES_URL }}"
+            VITE_SITE_NAME="${{ secrets.PREVIEW_VITE_SITE_NAME }}"
+            VITE_THEME="${{ secrets.PREVIEW_VITE_THEME }}"
+            VITE_DONATIONS_BODY="${{ secrets.PREVIEW_VITE_DONATIONS_BODY }}"
+            VITE_DONATIONS_IFRAME_SRC="${{ secrets.PREVIEW_VITE_DONATIONS_IFRAME_SRC }}"
+            VITE_DONATIONS_IMAGE_URL="${{ secrets.PREVIEW_VITE_DONATIONS_IMAGE_URL }}"
+            VITE_HOWTOS_HEADING="${{ secrets.PREVIEW_VITE_HOWTOS_HEADING }}"
+            VITE_COMMUNITY_PROGRAM_URL="${{ secrets.PREVIEW_VITE_COMMUNITY_PROGRAM_URL }}"
+            VITE_QUESTIONS_GUIDELINES_URL="${{ secrets.PREVIEW_VITE_QUESTIONS_GUIDELINES_URL }}"
\ No newline at end of file