Migrate linter configs within templates to v2#173
Merged
Conversation
aqdas0307
changed the title
jessjenkins
previously approved these changes
Nov 18, 2025
mr-nick17
suggested changes
Nov 18, 2025
Contributor
mr-nick17
left a comment
mr-nick17
left a comment
There was a problem hiding this comment.
you need to remove the unused paths
project_generation/content/templates/base-app/.golangci.yml.tmpl
Outdated
Show resolved
Hide resolved
project_generation/content/templates/base-app/.golangci.yml.tmpl
Outdated
Show resolved
Hide resolved
project_generation/content/templates/library/go/.golangci.yml.tmpl
Outdated
Show resolved
Hide resolved
project_generation/content/templates/library/go/.golangci.yml.tmpl
Outdated
Show resolved
Hide resolved
aqdas0307
force-pushed
the
feature/migrate-linter-config-v2
branch
from
07b6f5a to
555623b
Compare
mr-nick17
approved these changes
Nov 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Migrated linter configs within template to v2
How to review
Sense check
Confirm everything looks okay/in place
To test:
make buildexport PATH=/dp-cli:$PATH(relative to where you are to dp-cli)dp generate-projectand generate all templates belowmake lintwithin each of the generated templates and ensure there are 0 issuesWho can review
Not me