From 1626b8e55f293edae3d6c4dfe3ce85d75bb4beea Mon Sep 17 00:00:00 2001 From: Austin Adams Date: Wed, 18 Dec 2024 13:24:23 -0500 Subject: [PATCH] Address PR comments --- src/qiree/Module.cc | 3 ++- src/qirxacc/XaccQuantum.cc | 11 ----------- src/qirxacc/XaccQuantum.hh | 7 ------- 3 files changed, 2 insertions(+), 19 deletions(-) diff --git a/src/qiree/Module.cc b/src/qiree/Module.cc index 83d9703..d771eb0 100644 --- a/src/qiree/Module.cc +++ b/src/qiree/Module.cc @@ -116,6 +116,7 @@ Module::Module(UPModule&& module) : module_{std::move(module)} //---------------------------------------------------------------------------// /*! * Construct with an LLVM module and an entry point. + * Useful when there are multiple entry points. */ Module::Module(UPModule&& module, std::string const& entrypoint) : module_{std::move(module)} @@ -128,7 +129,6 @@ Module::Module(UPModule&& module, std::string const& entrypoint) << "no entrypoint function '" << entrypoint << "' exists"); } - //---------------------------------------------------------------------------// /*! * Construct with an LLVM IR file (bitcode or disassembled). @@ -141,6 +141,7 @@ Module::Module(std::string const& filename) //---------------------------------------------------------------------------// /*! * Construct with an LLVM IR file (bitcode or disassembled) and entry point. + * Useful when there are multiple entry points. */ Module::Module(std::string const& filename, std::string const& entrypoint) : module_{load_llvm_module(filename)} diff --git a/src/qirxacc/XaccQuantum.cc b/src/qirxacc/XaccQuantum.cc index 5141aee..336ba9a 100644 --- a/src/qirxacc/XaccQuantum.cc +++ b/src/qirxacc/XaccQuantum.cc @@ -77,17 +77,6 @@ XaccQuantum::~XaccQuantum() xacc::Finalize(); } -//---------------------------------------------------------------------------// -/*! - * Update the XACC accelerator and shot count. - */ -void XaccQuantum::set_accelerator_and_shots( - std::string const& accel_name, size_type shots) { - accelerator_ = xacc::getAccelerator(accel_name); - QIREE_VALIDATE(accelerator_, << "failed to create accelerator"); - accelerator_->updateConfiguration({{"shots", static_cast(shots)}}); -} - //---------------------------------------------------------------------------// /*! * Prepare to build a quantum circuit for an entry point. diff --git a/src/qirxacc/XaccQuantum.hh b/src/qirxacc/XaccQuantum.hh index 6f6bcf2..5a0c77c 100644 --- a/src/qirxacc/XaccQuantum.hh +++ b/src/qirxacc/XaccQuantum.hh @@ -58,13 +58,6 @@ class XaccQuantum final : virtual public QuantumNotImpl size_type num_qubits() const { return num_qubits_; } //!@} - //!@{ - //! \name Mutators - // Update the XACC accelerator and shot count - void set_accelerator_and_shots( - std::string const& accel_name, size_type shots); - //!@} - //!@{ //! \name Quantum interface // Prepare to build a quantum circuit for an entry point