-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DXF: add creation option to set and DXF system variables #11424
Conversation
229515f
to
9dd8963
Compare
@atlight I was wondering if using the CRS unit as a default for INSUNITS would be a sane default ? And what about MEASUREMENT (should it be related to CRS units?) ? For now, I've kept the values from header.dxf (inches / imperial) as the default |
9dd8963
to
20ed056
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't tested, but looks good to me. Just minor stuff here.
(Reading your comment after leaving my review) I think this makes a lot of sense. If your CRS is in metres you ideally should get a DXF in metres without taking any active steps to ensure that. Not really sure about MEASUREMENT, it doesn't seem very important. It's not something my company or our clients ever use. |
20ed056
to
c95e280
Compare
ok, I've remove the INSUNIT=FROM_CRS mode, and rather use a default INSUNIT=AUTO mode that tries to use the CRS info when available, and fallbacks to the value of the template header.dxf file |
c95e280
to
0d98f32
Compare
Fixes #11423