fix : narrow down the PLC0415 ignore list

Author: ishanBahuguna

backend/apps/ai/common/utils.py

@@ -40,8 +40,6 @@ def create_chunks_and_embeddings(
         ValueError: If context is None or invalid
 
     """
-    from apps.ai.models.chunk import Chunk
-
     try:
         last_request_time = datetime.now(UTC) - timedelta(
             seconds=DEFAULT_LAST_REQUEST_OFFSET_SECONDS
@@ -77,8 +75,6 @@ def regenerate_chunks_for_context(context: Context):
       context (Context): The specific context instance to be updated.
 
     """
-    from apps.ai.models.chunk import Chunk
-
     context.chunks.all().delete()
     new_chunk_texts = Chunk.split_text(context.content)
 

backend/pyproject.toml

@@ -68,21 +68,19 @@ line-length = 99
 lint.select = [ "ALL" ]
 lint.extend-select = [ "I" ]
 lint.ignore = [
-  "ANN",    # https://docs.astral.sh/ruff/rules/#flake8-annotations-ann/
-  "ARG002", # https://docs.astral.sh/ruff/rules/unused-method-argument/
-  "C901",   # https://docs.astral.sh/ruff/rules/complex-structure/
-  "COM812", # https://docs.astral.sh/ruff/rules/missing-trailing-comma/
-  "D407",   # https://docs.astral.sh/ruff/rules/missing-dashed-underline-after-section/
-  "DJ012",  # https://docs.astral.sh/ruff/rules/django-unordered-body-content-in-model/
-  "FIX002", # https://docs.astral.sh/ruff/rules/line-contains-todo/
-
+  "ANN",     # https://docs.astral.sh/ruff/rules/#flake8-annotations-ann/
+  "ARG002",  # https://docs.astral.sh/ruff/rules/unused-method-argument/
+  "C901",    # https://docs.astral.sh/ruff/rules/complex-structure/
+  "COM812",  # https://docs.astral.sh/ruff/rules/missing-trailing-comma/
+  "D407",    # https://docs.astral.sh/ruff/rules/missing-dashed-underline-after-section/
+  "DJ012",   # https://docs.astral.sh/ruff/rules/django-unordered-body-content-in-model/
+  "FIX002",  # https://docs.astral.sh/ruff/rules/line-contains-todo/
   "PLR0912", # https://docs.astral.sh/ruff/rules/too-many-branches/
   "PLR0913", # https://docs.astral.sh/ruff/rules/too-many-arguments/
   "PLR0915", # https://docs.astral.sh/ruff/rules/too-many-statements/
   "RUF012",  # https://docs.astral.sh/ruff/rules/mutable-class-default/
   "TD003",   # https://docs.astral.sh/ruff/rules/missing-todo-link/
 ]
-
 lint.per-file-ignores."**/__init__.py" = [
   "D104", # https://docs.astral.sh/ruff/rules/undocumented-public-package/
   "F401", # https://docs.astral.sh/ruff/rules/unused-import/
@@ -122,9 +120,6 @@ lint.per-file-ignores."**/tests/**/*.py" = [
 ]
 
 # specific files that need PLC0415 ignored
-lint.per-file-ignores."apps/ai/common/utils.py" = [
-  "PLC0415", # https://docs.astral.sh/ruff/rules/import-outside-top-level/
-]
 lint.per-file-ignores."apps/github/models/mixins/organization.py" = [
   "PLC0415", # https://docs.astral.sh/ruff/rules/import-outside-top-level/
 ]
@@ -164,45 +159,12 @@ lint.per-file-ignores."apps/slack/events/member_joined_channel/contribute.py" =
 lint.per-file-ignores."apps/slack/utils.py" = [
   "PLC0415", # https://docs.astral.sh/ruff/rules/import-outside-top-level/
 ]
-lint.per-file-ignores."tests/apps/ai/management/commands/ai_update_chapter_chunks_test.py" = [
-  "PLC0415", # https://docs.astral.sh/ruff/rules/import-outside-top-level/
-]
-lint.per-file-ignores."tests/apps/ai/management/commands/ai_update_chapter_context_test.py" = [
-  "PLC0415", # https://docs.astral.sh/ruff/rules/import-outside-top-level/
-]
-lint.per-file-ignores."tests/apps/ai/management/commands/ai_update_committee_chunks_test.py" = [
-  "PLC0415", # https://docs.astral.sh/ruff/rules/import-outside-top-level/
-]
-lint.per-file-ignores."tests/apps/ai/management/commands/ai_update_committee_context_test.py" = [
-  "PLC0415", # https://docs.astral.sh/ruff/rules/import-outside-top-level/
-]
-lint.per-file-ignores."tests/apps/ai/management/commands/ai_update_event_chunks_test.py" = [
-  "PLC0415", # https://docs.astral.sh/ruff/rules/import-outside-top-level/
-]
-lint.per-file-ignores."tests/apps/ai/management/commands/ai_update_event_context_test.py" = [
-  "PLC0415", # https://docs.astral.sh/ruff/rules/import-outside-top-level/
-]
-lint.per-file-ignores."tests/apps/ai/management/commands/ai_update_project_chunks_test.py" = [
-  "PLC0415", # https://docs.astral.sh/ruff/rules/import-outside-top-level/
-]
-lint.per-file-ignores."tests/apps/ai/management/commands/ai_update_project_context_test.py" = [
-  "PLC0415", # https://docs.astral.sh/ruff/rules/import-outside-top-level/
-]
-lint.per-file-ignores."tests/apps/ai/management/commands/ai_update_slack_message_chunks_test.py" = [
-  "PLC0415", # https://docs.astral.sh/ruff/rules/import-outside-top-level/
-]
-lint.per-file-ignores."tests/apps/ai/management/commands/ai_update_slack_message_context_test.py" = [
-  "PLC0415", # https://docs.astral.sh/ruff/rules/import-outside-top-level/
-]
 lint.per-file-ignores."tests/apps/ai/models/chunk_test.py" = [
   "PLC0415", # https://docs.astral.sh/ruff/rules/import-outside-top-level/
 ]
 lint.per-file-ignores."tests/apps/ai/models/context_test.py" = [
   "PLC0415", # https://docs.astral.sh/ruff/rules/import-outside-top-level/
 ]
-lint.per-file-ignores."tests/apps/github/management/commands/github_get_installation_id_test.py" = [
-  "PLC0415", # https://docs.astral.sh/ruff/rules/import-outside-top-level/
-]
 lint.per-file-ignores."tests/apps/slack/views_test.py" = [
   "PLC0415", # https://docs.astral.sh/ruff/rules/import-outside-top-level/
 ]

backend/tests/apps/ai/management/commands/ai_update_chapter_chunks_test.py

@@ -4,6 +4,7 @@
 from django.core.management.base import BaseCommand
 
 from apps.ai.management.commands.ai_update_chapter_chunks import Command
+from apps.owasp.models.chapter import Chapter
 
 
 @pytest.fixture
@@ -24,8 +25,6 @@ def test_command_inheritance(self, command):
         assert isinstance(command, BaseCommand)
 
     def test_model_class_property(self, command):
-        from apps.owasp.models.chapter import Chapter
-
         assert command.model_class == Chapter
 
     def test_entity_name_property(self, command):

backend/tests/apps/ai/management/commands/ai_update_chapter_context_test.py

@@ -4,7 +4,9 @@
 
 import pytest
 
+from apps.ai.common.base.context_command import BaseContextCommand
 from apps.ai.management.commands.ai_update_chapter_context import Command
+from apps.owasp.models.chapter import Chapter
 
 
 @pytest.fixture
@@ -23,8 +25,6 @@ def mock_chapter():
 class TestAiCreateChapterContextCommand:
     def test_command_inheritance(self, command):
         """Test that the command inherits from BaseContextCommand."""
-        from apps.ai.common.base.context_command import BaseContextCommand
-
         assert isinstance(command, BaseContextCommand)
 
     def test_command_help_text(self, command):
@@ -33,8 +33,6 @@ def test_command_help_text(self, command):
 
     def test_model_class_property(self, command):
         """Test the model_class property returns Chapter."""
-        from apps.owasp.models.chapter import Chapter
-
         assert command.model_class == Chapter
 
     def test_entity_name_property(self, command):

backend/tests/apps/ai/management/commands/ai_update_committee_chunks_test.py

@@ -6,6 +6,7 @@
 from django.core.management.base import BaseCommand
 
 from apps.ai.management.commands.ai_update_committee_chunks import Command
+from apps.owasp.models.committee import Committee
 
 
 @pytest.fixture
@@ -35,8 +36,6 @@ def test_command_inheritance(self, command):
 
     def test_model_class_method(self, command):
         """Test the model_class method returns Committee."""
-        from apps.owasp.models.committee import Committee
-
         assert command.model_class == Committee
 
     def test_entity_name_method(self, command):

backend/tests/apps/ai/management/commands/ai_update_committee_context_test.py

@@ -4,7 +4,9 @@
 
 import pytest
 
+from apps.ai.common.base.context_command import BaseContextCommand
 from apps.ai.management.commands.ai_update_committee_context import Command
+from apps.owasp.models.committee import Committee
 
 
 @pytest.fixture
@@ -30,8 +32,6 @@ class TestAiCreateCommitteeContextCommand:
 
     def test_command_inheritance(self, command):
         """Test that the command inherits from BaseContextCommand."""
-        from apps.ai.common.base.context_command import BaseContextCommand
-
         assert isinstance(command, BaseContextCommand)
 
     def test_command_help_text(self, command):
@@ -40,8 +40,6 @@ def test_command_help_text(self, command):
 
     def test_model_class_method(self, command):
         """Test the model_class method returns Committee."""
-        from apps.owasp.models.committee import Committee
-
         assert command.model_class == Committee
 
     def test_entity_name_method(self, command):

backend/tests/apps/ai/management/commands/ai_update_event_chunks_test.py

@@ -6,6 +6,7 @@
 from django.core.management.base import BaseCommand
 
 from apps.ai.management.commands.ai_update_event_chunks import Command
+from apps.owasp.models.event import Event
 
 
 @pytest.fixture
@@ -32,8 +33,6 @@ def test_command_inheritance(self, command):
 
     def test_model_class_property(self, command):
         """Test the model_class property returns Event."""
-        from apps.owasp.models.event import Event
-
         assert command.model_class == Event
 
     def test_entity_name_property(self, command):

backend/tests/apps/ai/management/commands/ai_update_event_context_test.py

@@ -4,7 +4,9 @@
 
 import pytest
 
+from apps.ai.common.base.context_command import BaseContextCommand
 from apps.ai.management.commands.ai_update_event_context import Command
+from apps.owasp.models.event import Event
 
 
 @pytest.fixture
@@ -23,8 +25,6 @@ def mock_event():
 class TestAiCreateEventContextCommand:
     def test_command_inheritance(self, command):
         """Test that the command inherits from BaseContextCommand."""
-        from apps.ai.common.base.context_command import BaseContextCommand
-
         assert isinstance(command, BaseContextCommand)
 
     def test_command_help_text(self, command):
@@ -33,8 +33,6 @@ def test_command_help_text(self, command):
 
     def test_model_class_property(self, command):
         """Test the model_class property returns Event."""
-        from apps.owasp.models.event import Event
-
         assert command.model_class == Event
 
     def test_entity_name_property(self, command):

backend/tests/apps/ai/management/commands/ai_update_project_chunks_test.py

@@ -4,6 +4,7 @@
 from django.core.management.base import BaseCommand
 
 from apps.ai.management.commands.ai_update_project_chunks import Command
+from apps.owasp.models.project import Project
 
 
 @pytest.fixture
@@ -24,8 +25,6 @@ def test_command_inheritance(self, command):
         assert isinstance(command, BaseCommand)
 
     def test_model_class_property(self, command):
-        from apps.owasp.models.project import Project
-
         assert command.model_class == Project
 
     def test_entity_name_property(self, command):

backend/tests/apps/ai/management/commands/ai_update_project_context_test.py

@@ -2,7 +2,9 @@
 
 import pytest
 
+from apps.ai.common.base.context_command import BaseContextCommand
 from apps.ai.management.commands.ai_update_project_context import Command
+from apps.owasp.models.project import Project
 
 
 @pytest.fixture
@@ -21,8 +23,6 @@ def mock_project():
 class TestAiCreateProjectContextCommand:
     def test_command_inheritance(self, command):
         """Test that the command inherits from BaseContextCommand."""
-        from apps.ai.common.base.context_command import BaseContextCommand
-
         assert isinstance(command, BaseContextCommand)
 
     def test_command_help_text(self, command):
@@ -31,8 +31,6 @@ def test_command_help_text(self, command):
 
     def test_model_class_property(self, command):
         """Test the model_class property returns Project."""
-        from apps.owasp.models.project import Project
-
         assert command.model_class == Project
 
     def test_entity_name_property(self, command):