From 026a9391dc8a0f67f864e61d9d5fddb895661a0d Mon Sep 17 00:00:00 2001 From: bl13bl03p <22095577+bl13pbl03p@users.noreply.github.com> Date: Sun, 21 May 2023 13:12:03 +0200 Subject: [PATCH 1/3] Changed value of status_cells in yaml_to_excel.py Closes #2415 except for the MASVS-AUTH MASVS-CODE tab. Separate rule should be made to fix 'status dropdown bar issue' in the remaining tabs. --- tools/scripts/yaml_to_excel.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/scripts/yaml_to_excel.py b/tools/scripts/yaml_to_excel.py index 37595a2aee..22fc691b89 100644 --- a/tools/scripts/yaml_to_excel.py +++ b/tools/scripts/yaml_to_excel.py @@ -153,7 +153,7 @@ def create_security_requirements_sheet(wb): write_header(ws, category_title, mas_styles.MASVS_COLORS[group_id]) set_columns_width(ws) - status_cells = 'H8:L400' + status_cells = 'I13:L400' ws.conditional_formatting.add(status_cells, mas_styles.rule_fail) ws.conditional_formatting.add(status_cells, mas_styles.rule_pass) ws.conditional_formatting.add(status_cells, mas_styles.rule_na) From b99f253548fb985f1d0e01716165e9d9f6d2f952 Mon Sep 17 00:00:00 2001 From: Carlos Holguera Date: Mon, 22 May 2023 21:09:10 +0200 Subject: [PATCH 2/3] Additional fix for the status column to be only "I" --- tools/scripts/yaml_to_excel.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/scripts/yaml_to_excel.py b/tools/scripts/yaml_to_excel.py index 22fc691b89..86dfb317c4 100644 --- a/tools/scripts/yaml_to_excel.py +++ b/tools/scripts/yaml_to_excel.py @@ -153,7 +153,7 @@ def create_security_requirements_sheet(wb): write_header(ws, category_title, mas_styles.MASVS_COLORS[group_id]) set_columns_width(ws) - status_cells = 'I13:L400' + status_cells = 'I13:I400' ws.conditional_formatting.add(status_cells, mas_styles.rule_fail) ws.conditional_formatting.add(status_cells, mas_styles.rule_pass) ws.conditional_formatting.add(status_cells, mas_styles.rule_na) From 397f485f05725261b30b867fbc61b6d3a474f139 Mon Sep 17 00:00:00 2001 From: Carlos Holguera Date: Mon, 22 May 2023 21:13:03 +0200 Subject: [PATCH 3/3] Another fix so that we can also mark the first control, not only tests. --- tools/scripts/yaml_to_excel.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/scripts/yaml_to_excel.py b/tools/scripts/yaml_to_excel.py index 86dfb317c4..fa09dac041 100644 --- a/tools/scripts/yaml_to_excel.py +++ b/tools/scripts/yaml_to_excel.py @@ -153,7 +153,7 @@ def create_security_requirements_sheet(wb): write_header(ws, category_title, mas_styles.MASVS_COLORS[group_id]) set_columns_width(ws) - status_cells = 'I13:I400' + status_cells = 'I11:I400' ws.conditional_formatting.add(status_cells, mas_styles.rule_fail) ws.conditional_formatting.add(status_cells, mas_styles.rule_pass) ws.conditional_formatting.add(status_cells, mas_styles.rule_na)