From 291360d90397560c30a2de8fbeef79f5a12a62c3 Mon Sep 17 00:00:00 2001 From: Erik van Sebille Date: Thu, 8 Feb 2024 17:34:23 +0100 Subject: [PATCH 1/2] Adding explanation to Kernelloop tutorial on order of StatusCode kernels This addresses #1507 --- docs/examples/tutorial_kernelloop.ipynb | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/docs/examples/tutorial_kernelloop.ipynb b/docs/examples/tutorial_kernelloop.ipynb index 1a24aec57..e1cef4f34 100644 --- a/docs/examples/tutorial_kernelloop.ipynb +++ b/docs/examples/tutorial_kernelloop.ipynb @@ -413,7 +413,9 @@ "cell_type": "markdown", "metadata": {}, "source": [ - "Kernel functions such as the ones above can then be added to the list of kernels in `pset.execute()`." + "Kernel functions such as the ones above can then be added to the list of kernels in `pset.execute()`. \n", + "\n", + "Note that these Kernels that control what to do with `particle.state` should typically be added at the _end_ of the Kernel list, because otherwise later Kernels may overwrite the `particle.state` or the `particle_dlon` variables." ] } ], From a4ffa165f35e5192e9e6b8b6b73cb06086a6339f Mon Sep 17 00:00:00 2001 From: Erik van Sebille Date: Thu, 8 Feb 2024 17:35:08 +0100 Subject: [PATCH 2/2] Expanding error message for unexpected fieldsize --- parcels/field.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/parcels/field.py b/parcels/field.py index 294d2c0d7..ece0f9c53 100644 --- a/parcels/field.py +++ b/parcels/field.py @@ -510,8 +510,9 @@ def from_netcdf(cls, filenames, variable, dimensions, indices=None, grid=None, filebuffer.name = filebuffer.parse_name(variable[1]) buffer_data = filebuffer.data if len(buffer_data.shape) == 4: - errormessage = (f'Field {filebuffer.name} expecting a data shape of [tdim, zdim, ydim, xdim]. ' - 'Flag transpose=True could help to reorder the data.') + errormessage = (f'Field {filebuffer.name} expecting a data shape of [tdim={grid.tdim}, zdim={grid.zdim}, ' + f'ydim={grid.ydim - 2 * grid.meridional_halo}, xdim={grid.xdim - 2 * grid.zonal_halo}] ' + f'but got shape {buffer_data.shape}. Flag transpose=True could help to reorder the data.') assert buffer_data.shape[0] == grid.tdim, errormessage assert buffer_data.shape[2] == grid.ydim - 2 * grid.meridional_halo, errormessage assert buffer_data.shape[3] == grid.xdim - 2 * grid.zonal_halo, errormessage