Allowing for different netcdf engine in Field.from_netcdf #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
parcels/field.py
Outdated
| @@ -50,6 +50,8 @@ class Field(object): | |||
| (i.e. beyond the last available time snapshot) | |||
| :param time_periodic: boolean whether to loop periodically over the time component of the Field | |||
| This flag overrides the allow_time_interpolation and sets it to False | |||
| :param netcdf_engine: engine to use for netcdf reading in xarray. Default is 'netcdf', | |||
| but in cases where this doesn't work, setting netcdf_engine='scipy' could help | |||
There was a problem hiding this comment.
Why is this doc here in Field constructor? Shouldn't it be in Field.from_netcdf() and same for FieldSet.from_netcdf()?
parcels/field.py
Outdated
| @@ -198,6 +202,7 @@ def from_netcdf(cls, filenames, variable, dimensions, indices=None, grid=None, | |||
| grid = CurvilinearSGrid(lon, lat, depth, time, time_origin=time_origin, mesh=mesh) | |||
| grid.timeslices = timeslices | |||
| kwargs['dataFiles'] = dataFiles | |||
| kwargs['netcdf_engine'] = netcdf_engine | |||
There was a problem hiding this comment.
why is this in if grid is None and not later with other kwargs (at the end of the function)
delandmeterp
approved these changes
Sep 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some files (e.g. the MITgcm files of Issue #453) lead to errors when openend by Field.from_netcdf() because the default netcdf4 engine of
xarraycan't read them.For these files, this PR now provides the option to specify
netcdf_engine='scipy'in the Field.from_netcdf and FieldSet.from_netcdf constructors