Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New kernel order #503

Merged
merged 21 commits into from
Dec 18, 2018
Merged

New kernel order #503

merged 21 commits into from
Dec 18, 2018

Conversation

delandmeterp
Copy link
Contributor

@delandmeterp delandmeterp commented Dec 11, 2018

This is a major change!

Basically, the order of arguments is changed when interpolating a field.
Field[time, lon, lat, depth] becomes Field[time, depth, lat, lon]

To add some safety to this change, we removed the un-necessary dt arguments in kernel such that current kernels, that are likely interpolating fields using the old order, break.

But also, any interpolation outside a kernel can potentially break without previous notification.

Apart from checking the changes in the current PR, it is then also important to check what could have been forgotten in the code (for example, I had to modify some interpolation calls outside kernels)

@delandmeterp delandmeterp changed the title WIP: New kernel order New kernel order Dec 12, 2018
Copy link
Member

@erikvansebille erikvansebille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Large update; looks all good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants