-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chunked fields operational #632
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
since scipy interp needs np.arrays so far
(in computeTimeChunk)
but field shares a grid with another one that does
This forces deletion of objects that were stuck in a reference loop
+ no rechunk of data anymore
Suggestion of @angus-g
…parcels into chunked_fields_operational
compute function
da.concatenate cannot concat data[range()], such that we have to open range(a, b) into range.start:range.stop
on travis py3 linux
delandmeterp
commented
Sep 3, 2019
if __del__ is defined https://pymotw.com/2/gc/
erikvansebille
approved these changes
Sep 4, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR splits the field_data into chunks.
Field.data
is not anp.array
anymore but a lazily loadedda.array
.If a JIT kernel needs to interpolate data within a chunk, this chunk is loaded into memory.
In Scipy,
pset.execute()
first converts allField.data
intonp.array
s.To do
Field.gradient()
Field.chunk_data()
into an initial call and what is called during simuField.chunk_data
should be moved toField.grid.chunk_data
where
grid.load_chunk_data
will not be matching with loadedV
chunks-> solution here is to attach
load_chunk_data
to the field itself...NO, it does not work, since really not efficient
-> we keep it on grid, but in chunk_data, we also load the data also if it's not loaded yet, but then we also need to set chunk_data back to None at the pset.execute() if it't not used by kernels!
pset.execute(dt=0)
?