Merge pull request #40 from Ocramius/feature/mutation-testing

Mutation testing, PHP 7.1 testing

.gitattributes

@@ -6,3 +6,4 @@
 .travis.install.sh export-ignore
 .travis.yml export-ignore
 phpunit.xml.dist export-ignore
+humbug.json.dist

.gitignore

@@ -1,4 +1,6 @@
 /vendor/
 src/PackageVersions/Versions.php
 composer.lock
-clover.xml
+clover.xml
+humbuglog.txt
+humbuglog.json

.travis.yml

@@ -4,6 +4,7 @@ sudo: false
 
 php:
   - 7.0
+  - 7.1
 
 env:
   - DEPENDENCIES=""
@@ -16,6 +17,7 @@ before_script:
 
 script:
   - ./vendor/bin/phpunit --disallow-test-output --report-useless-tests --coverage-clover ./clover.xml
+  - ./vendor/bin/humbug
 
 after_script:
   - sh .travis.coverage.sh

composer.json

@@ -14,7 +14,8 @@
         "composer-plugin-api": "^1.0"
     },
     "require-dev": {
-        "phpunit/phpunit":   "^5.4.7",
+        "phpunit/phpunit":   "^5.7.5",
+        "humbug/humbug":     "dev-master",
         "composer/composer": "^1.3",
         "ext-zip":           "*"
     },

humbug.json.dist

@@ -0,0 +1,12 @@
+{
+    "source": {
+        "directories": [
+            "src"
+        ]
+    },
+    "timeout": 10,
+    "logs": {
+        "text": "humbuglog.txt",
+        "json": "humbuglog.json"
+    }
+}

src/PackageVersions/Installer.php

@@ -124,12 +124,11 @@ private static function writeVersionClassToFile(
         Config $composerConfig,
         RootPackageInterface $rootPackage
     ) {
-        file_put_contents(
-            self::locateRootPackageInstallPath($composerConfig, $rootPackage)
-            . '/src/PackageVersions/Versions.php',
-            $versionClassSource,
-            0664
-        );
+        $installPath = self::locateRootPackageInstallPath($composerConfig, $rootPackage)
+            . '/src/PackageVersions/Versions.php';
+
+        file_put_contents($installPath, $versionClassSource);
+        chmod($installPath, 0664);
     }
 
     /**

test/PackageVersionsTest/InstallerTest.php

@@ -89,6 +89,7 @@ public function testDumpVersionsClass()
 
         $expectedPath = $vendorDir . '/ocramius/package-versions/src/PackageVersions';
 
+        /** @noinspection MkdirRaceConditionInspection */
         mkdir($expectedPath, 0777, true);
 
         $locker
@@ -206,6 +207,7 @@ public function testDumpVersionsClassNoDev()
 
         $expectedPath = $vendorDir . '/ocramius/package-versions/src/PackageVersions';
 
+        /** @noinspection MkdirRaceConditionInspection */
         mkdir($expectedPath, 0777, true);
 
         $locker
@@ -318,6 +320,7 @@ public function testDumpVersionsWithoutPackageSourceDetails()
 
         $expectedPath = $vendorDir . '/ocramius/package-versions/src/PackageVersions';
 
+        /** @noinspection MkdirRaceConditionInspection */
         mkdir($expectedPath, 0777, true);
 
         $locker
@@ -427,12 +430,15 @@ public function testDumpsVersionsClassToSpecificLocation(RootPackageInterface $r
 
         $vendorDir = sys_get_temp_dir() . '/' . uniqid('InstallerTest', true) . '/vendor';
 
+        /** @noinspection MkdirRaceConditionInspection */
         mkdir($vendorDir, 0777, true);
 
-        $expectedPath = $inVendor
+        /** @noinspection RealpathInSteamContextInspection */
+        $expectedPath      = $inVendor
             ? $vendorDir . '/ocramius/package-versions/src/PackageVersions'
             : realpath($vendorDir . '/..') . '/src/PackageVersions';
 
+        /** @noinspection MkdirRaceConditionInspection */
         mkdir($expectedPath, 0777, true);
 
         $locker
@@ -530,6 +536,7 @@ public function testVersionsAreNotDumpedIfPackageVersionsNotExplicitlyRequired()
 
         $expectedPath = $vendorDir . '/ocramius/package-versions/src/PackageVersions';
 
+        /** @noinspection MkdirRaceConditionInspection */
         mkdir($expectedPath, 0777, true);
 
         $locker
@@ -576,6 +583,66 @@ public function testVersionsAreNotDumpedIfPackageVersionsNotExplicitlyRequired()
         $this->rmDir($vendorDir);
     }
 
+    public function testGeneratedVersionFileAccessRights()
+    {
+        if (0 === strpos(\PHP_OS, 'WIN')) {
+            $this->markTestSkipped('Windows is kinda "meh" at file access levels');
+        }
+
+        $config            = $this->getMockBuilder(Config::class)->disableOriginalConstructor()->getMock();
+        $locker            = $this->getMockBuilder(Locker::class)->disableOriginalConstructor()->getMock();
+        $repositoryManager = $this->getMockBuilder(RepositoryManager::class)->disableOriginalConstructor()->getMock();
+        $installManager    = $this->getMockBuilder(InstallationManager::class)->disableOriginalConstructor()->getMock();
+        $repository        = $this->createMock(InstalledRepositoryInterface::class);
+        $package           = $this->createMock(RootPackageInterface::class);
+
+        $vendorDir = sys_get_temp_dir() . '/' . uniqid('InstallerTest', true);
+
+        $expectedPath = $vendorDir . '/ocramius/package-versions/src/PackageVersions';
+
+        /** @noinspection MkdirRaceConditionInspection */
+        mkdir($expectedPath, 0777, true);
+
+        $locker
+            ->expects(self::any())
+            ->method('getLockData')
+            ->willReturn([
+                'packages' => [
+                    [
+                        'name'    => 'ocramius/package-versions',
+                        'version' => '1.0.0',
+                    ],
+                ],
+            ]);
+
+        $repositoryManager->expects(self::any())->method('getLocalRepository')->willReturn($repository);
+
+        $this->composer->expects(self::any())->method('getConfig')->willReturn($config);
+        $this->composer->expects(self::any())->method('getLocker')->willReturn($locker);
+        $this->composer->expects(self::any())->method('getRepositoryManager')->willReturn($repositoryManager);
+        $this->composer->expects(self::any())->method('getPackage')->willReturn($package);
+        $this->composer->expects(self::any())->method('getInstallationManager')->willReturn($installManager);
+
+        $package->expects(self::any())->method('getName')->willReturn('root/package');
+        $package->expects(self::any())->method('getVersion')->willReturn('1.3.5');
+        $package->expects(self::any())->method('getSourceReference')->willReturn('aaabbbcccddd');
+
+        $config->expects(self::any())->method('get')->with('vendor-dir')->willReturn($vendorDir);
+
+        Installer::dumpVersionsClass(new Event(
+            'post-install-cmd',
+            $this->composer,
+            $this->io
+        ));
+
+        $filePath = $expectedPath . '/Versions.php';
+
+        self::assertFileExists($filePath);
+        self::assertSame('0664', substr(sprintf('%o', fileperms($filePath)), -4));
+
+        $this->rmDir($vendorDir);
+    }
+
     /**
      * @param string $directory
      *