Mutation testing, PHP 7.1 testing #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…`umask()` defaults prevent malicious content injection via race conditions
kalessil
reviewed
Dec 30, 2016
| @@ -89,6 +89,7 @@ public function testDumpVersionsClass() | |||
|
|
|||
| $expectedPath = $vendorDir . '/ocramius/package-versions/src/PackageVersions'; | |||
|
|
|||
| /** @noinspection MkdirRaceConditionInspection */ | |||
There was a problem hiding this comment.
@Ocramius : I'd just ignore test-classes in the inspection, bunch of inspection are doing ths already.
kalessil
reviewed
Dec 30, 2016
| . '/src/PackageVersions/Versions.php'; | ||
|
|
||
| file_put_contents($installPath, $versionClassSource); | ||
| chmod($installPath, 0664); |
There was a problem hiding this comment.
@Ocramius : perhaps we should have an inspection for this?
There was a problem hiding this comment.
A default umask() will usually be 0022 or such, so it is generally OK to use file_put_contents(), but this file is a generated PHP file, and therefore vulnerable to code injection if the umask() is incorrect.
Interestingly, specifying the mask on file_put_contents() doesn't behave as expected :S
There was a problem hiding this comment.
chmod($installPath, 0664 & ~umask())?
PS: not tested but takes into account FS attributes
malukenho
approved these changes
Apr 20, 2017
|
Merging as per @malukenho's approval |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enforces mutation testing on the package.