Avoid constructor override #175

Ocramius · 2014-09-28T13:35:52Z

Ocramius · 2014-09-28T13:37:12Z

Ping @malukenho for review :-)

blanchonvincent · 2014-09-28T13:50:37Z

what a big change! interesting, but the php5.6 dependence should make problem for a lot of people to update PM to the 2.0.0 version

Ocramius · 2014-09-28T14:00:34Z

I really want to move to 1.0.0 and then start working on 2.0.0 by breaking BC mainly with minimum required versions.

This change should make ProxyManager 100% LSP-compliant

Pittiplatsch · 2014-09-28T17:02:13Z

...er/ProxyGenerator/AccessInterceptorScopeLocalizer/MethodGenerator/StaticProxyConstructor.php

+            . "\n\n";
+
+        foreach ($originalClass->getProperties() as $originalProperty) {
+            if ((PHP_VERSION_ID < 50400 || (defined('HHVM_VERSION'))) && $originalProperty->isPrivate()) {


Minor performance optimization:
Render (PHP_VERSION_ID < 50400 || (defined('HHVM_VERSION')) into local variable before foreach loop.

PHP_VERSION_ID < 50400 can be removed anyway since the composer.json file says that php 5.6 is a minimum version now.

This should go away with a rebase: I fixed it by using method_exists('Closure', 'bind') instead

Ocramius · 2014-10-01T11:23:50Z

@blanchonvincent the 5.6 requirement is mainly because (new ReflectionClass('Foo'))->newInstanceWithoutConstructor() works well in 5.6, while it requires doctrine/instantiator for PHP <= 5.5 :-\

Pittiplatsch · 2014-10-01T13:05:31Z

ReflectionClass::newInstanceWithoutConstructor() requires PHP 5.4+, doesn't it?
http://php.net/manual/en/reflectionclass.newinstancewithoutconstructor.php
Edit: Support for "all except final" classes with 5.6 - sorry, my bad :-(

Ocramius · 2014-10-01T13:16:49Z

ReflectionClass::newInstanceWithoutConstructor() requires PHP 5.4+, doesn't it?

Yes, but in 5.4 and 5.5, you can't use it with anything either extending or being an internal php class. PHP 5.6 is much better on that front.

…as of #115 and #175

…lass' constructors as of #115 and #175

…r (failing)

Ocramius · 2014-10-01T23:05:49Z

This is ready for merge, but 1.0.0 bugs still need resolution first.

…construct`

… codegen

…derMock`

…ble as well)

…ion checks

…er to initialize some proxy properties all the time

Avoid constructor override

…e as of #115 and #175)

#115 and #175)

…115 and #175)

…and #175)

…#115 and #175)

…and #175)

Cleanup: unused classes removal (constructors, not needed as per #115 and #175)

…e as of Ocramius#115 and Ocramius#175)

Ocramius#115 and Ocramius#175)

…cramius#115 and Ocramius#175)

…mius#115 and Ocramius#175)

…Ocramius#115 and Ocramius#175)

…mius#115 and Ocramius#175)

Ocramius added this to the 2.0.0 milestone Sep 28, 2014

Ocramius added the enhancement label Sep 28, 2014

Ocramius added the BC break label Sep 28, 2014

Ocramius self-assigned this Sep 28, 2014

Pittiplatsch reviewed Sep 28, 2014
View reviewed changes

Ocramius force-pushed the hotfix/avoid-constructor-override branch from a302221 to 0a61ffc Compare October 1, 2014 11:56

Ocramius force-pushed the hotfix/avoid-constructor-override branch 2 times, most recently from dee235c to b948637 Compare October 1, 2014 17:17

Ocramius added a commit that referenced this pull request Oct 1, 2014

Adding test asset to verify that proxy constructors work as expected …

e1bbfde

…as of #115 and #175

Ocramius added a commit that referenced this pull request Oct 1, 2014

Adding test to verify that proxy constructors work like the proxied c…

3bf1b73

…lass' constructors as of #115 and #175

Ocramius added a commit that referenced this pull request Oct 1, 2014

Implementing tests to cover #115 and #175 in lazy loading ghost logic

3ad6a64

Ocramius added a commit that referenced this pull request Oct 1, 2014

Implementing tests to cover #115 and #175 in lazy loading value holde…

667718d

…r (failing)

Ocramius changed the title ~~[WIP] Avoid constructor override~~ Avoid constructor override Oct 5, 2014

Ocramius mentioned this pull request Oct 25, 2014

Ideas/considerations for GhostObject Proxies lazy loading #159

Closed

Ocramius added 6 commits December 14, 2014 00:30

Implementing a static constructor to avoid overriding an object's `__…

17c8eb1

…construct`

Using the static constructor in the AccessInterceptorScopeLocalizer…

f94ebf1

… codegen

Implementing new static constructor in the `AccessInterceptorValueHol…

ec200ac

…derMock`

Variable collision fix ($instance was a parameter and a local varia…

1ffaf9c

…ble as well)

Using the new static proxy constructor where implemented

59049d1

Avoiding usage of $this in static context

28d73f0

Ocramius added 9 commits December 14, 2014 00:47

PHP/HHVM compat should be checked via method_exists(), not via vers…

e8ae065

…ion checks

CS fix - whitespace removal

05c9b17

Removed unused import

3b996ab

CS fix - docblock alignment

62812b7

CS fix - docblock alignment

57f78db

CS fix - docblock alignment

89d0519

CS fix - docblock alignment

0284096

Importing used classes, optimizing imports

10d21fa

Add overriding constructor to the generated value holder proxy in ord…

cc610f3

…er to initialize some proxy properties all the time

Ocramius force-pushed the hotfix/avoid-constructor-override branch from 04fec2e to cc610f3 Compare December 14, 2014 01:53

ClassGeneratorUtilsTest is part of coverage tests

15fcde7

Ocramius added a commit that referenced this pull request Dec 14, 2014

Merge pull request #175 from Ocramius/hotfix/avoid-constructor-override

99869b3

Avoid constructor override

Ocramius merged commit 99869b3 into master Dec 14, 2014

Ocramius deleted the hotfix/avoid-constructor-override branch December 14, 2014 02:04

This was referenced Dec 14, 2014

RFC: Recited: Give me my constructor back #115

Closed

Removal of PHP 5.3 support #128

Closed

Ocramius added a commit that referenced this pull request Dec 20, 2014

Removing unused method generator test (constructor is not used anymor…

98c88ea

…e as of #115 and #175)

Ocramius added a commit that referenced this pull request Dec 20, 2014

Removing unused method generator (constructor is not used anymore as of

85bef56

#115 and #175)

Ocramius added a commit that referenced this pull request Dec 20, 2014

Removing unused method generator test (constructor not required as of #…

05fde82

…115 and #175)

Ocramius added a commit that referenced this pull request Dec 20, 2014

Removing unused method generator (constructor not required as of #115 …

2ca4fcf

…and #175)

Ocramius added a commit that referenced this pull request Dec 20, 2014

Removing unused method generator tests (constructor not required as of …

14197e9

…#115 and #175)

Ocramius added a commit that referenced this pull request Dec 20, 2014

Removing unused method generator (constructor not required as of #115 …

496403c

…and #175)

Ocramius mentioned this pull request Dec 20, 2014

Cleanup: unused classes removal (constructors, not needed as per #115 and #175) #214

Merged

Ocramius added a commit that referenced this pull request Dec 20, 2014

Merge pull request #214 from Ocramius/cleanup/unused-classes-removal

5f7b0de

Cleanup: unused classes removal (constructors, not needed as per #115 and #175)

malukenho pushed a commit to malukenho/ProxyManager that referenced this pull request Jan 3, 2015

Removing unused method generator test (constructor is not used anymor…

4f4365e

…e as of Ocramius#115 and Ocramius#175)

malukenho pushed a commit to malukenho/ProxyManager that referenced this pull request Jan 3, 2015

Removing unused method generator (constructor is not used anymore as of

3d4113f

Ocramius#115 and Ocramius#175)

malukenho pushed a commit to malukenho/ProxyManager that referenced this pull request Jan 3, 2015

Removing unused method generator test (constructor not required as of O…

24d7ab8

…cramius#115 and Ocramius#175)

malukenho pushed a commit to malukenho/ProxyManager that referenced this pull request Jan 3, 2015

Removing unused method generator (constructor not required as of Ocra…

cf57e5c

…mius#115 and Ocramius#175)

malukenho pushed a commit to malukenho/ProxyManager that referenced this pull request Jan 3, 2015

Removing unused method generator tests (constructor not required as of …

d4eb07a

…Ocramius#115 and Ocramius#175)

malukenho pushed a commit to malukenho/ProxyManager that referenced this pull request Jan 3, 2015

Removing unused method generator (constructor not required as of Ocra…

968e602

…mius#115 and Ocramius#175)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Avoid constructor override #175

Avoid constructor override #175

Ocramius commented Sep 28, 2014

Ocramius commented Sep 28, 2014

blanchonvincent commented Sep 28, 2014

Ocramius commented Sep 28, 2014

Pittiplatsch Sep 28, 2014

GrahamCampbell Sep 28, 2014

Ocramius Oct 1, 2014

Ocramius commented Oct 1, 2014

Pittiplatsch commented Oct 1, 2014

Ocramius commented Oct 1, 2014

Ocramius commented Oct 1, 2014

Avoid constructor override #175

Avoid constructor override #175

Conversation

Ocramius commented Sep 28, 2014

Ocramius commented Sep 28, 2014

blanchonvincent commented Sep 28, 2014

Ocramius commented Sep 28, 2014

Pittiplatsch Sep 28, 2014

Choose a reason for hiding this comment

GrahamCampbell Sep 28, 2014

Choose a reason for hiding this comment

Ocramius Oct 1, 2014

Choose a reason for hiding this comment

Ocramius commented Oct 1, 2014

Pittiplatsch commented Oct 1, 2014

Ocramius commented Oct 1, 2014

Ocramius commented Oct 1, 2014