Skip to content

Commit ed081b0

Browse files
committed
[No Results] Changed message when no items set
1 parent 7548eeb commit ed081b0

File tree

2 files changed

+16
-32
lines changed

2 files changed

+16
-32
lines changed

app/src/main/java/de/davis/passwordmanager/ui/dashboard/DashboardFragment.java

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -75,8 +75,6 @@ public void onViewCreated(@NonNull View view, @Nullable Bundle savedInstanceStat
7575

7676
((AppCompatActivity)requireActivity()).setSupportActionBar(binding.listPane.searchBar);
7777

78-
binding.listPane.viewAddFirst.setOnClickListener(v -> showBottomSheet());
79-
8078
ActivityResultManager arm = ActivityResultManager.getOrCreateManager(getClass(), this);
8179
arm.registerCreate();
8280
arm.registerEdit(null);
@@ -87,7 +85,7 @@ public void onViewCreated(@NonNull View view, @Nullable Bundle savedInstanceStat
8785
binding.listPane.progress.setVisibility(View.GONE);
8886

8987
binding.listPane.recyclerView.setVisibility(hasElements ? View.VISIBLE : View.GONE);
90-
binding.listPane.viewToShow.setVisibility(hasElements ? View.GONE : View.VISIBLE);
88+
binding.listPane.noResults.setVisibility(hasElements ? View.GONE : View.VISIBLE);
9189
});
9290

9391
DashboardAdapter dashboardAdapter = manager.getAdapter();
@@ -133,11 +131,11 @@ public void afterTextChanged(Editable s) {
133131
searchResultAdapter.update(secureElements);
134132
searchResultAdapter.setFilter(viewModel.getSearchQuery());
135133
if(!TextUtils.isEmpty(viewModel.getSearchQuery()) && secureElements.isEmpty()){
136-
binding.listPane.noResults.setVisibility(View.VISIBLE);
134+
binding.listPane.noResultsSearch.setVisibility(View.VISIBLE);
137135
return;
138136
}
139137

140-
binding.listPane.noResults.setVisibility(View.GONE);
138+
binding.listPane.noResultsSearch.setVisibility(View.GONE);
141139
});
142140

143141

app/src/main/res/layout/list_pane.xml

Lines changed: 13 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -12,19 +12,20 @@
1212
android:layout_height="match_parent"
1313
android:visibility="gone"
1414
app:layoutManager="de.davis.passwordmanager.ui.LinearLayoutManager"
15-
app:layout_behavior="de.davis.passwordmanager.ui.dashboard.DashboardFragment$ScrollingViewBehavior"/>
15+
app:layout_behavior="de.davis.passwordmanager.ui.dashboard.DashboardFragment$ScrollingViewBehavior" />
1616

1717
<com.google.android.material.appbar.AppBarLayout
1818
android:id="@+id/appbarLayout"
1919
android:layout_width="match_parent"
2020
android:layout_height="wrap_content"
2121
android:fitsSystemWindows="true">
22+
2223
<com.google.android.material.search.SearchBar
2324
android:id="@+id/search_bar"
2425
android:layout_width="match_parent"
2526
android:layout_height="wrap_content"
2627
android:hint="@android:string/search_go"
27-
app:forceDefaultNavigationOnClickListener="true"/>
28+
app:forceDefaultNavigationOnClickListener="true" />
2829
</com.google.android.material.appbar.AppBarLayout>
2930

3031
<com.google.android.material.search.SearchView
@@ -38,47 +39,32 @@
3839
android:id="@+id/recyclerViewResults"
3940
android:layout_width="match_parent"
4041
android:layout_height="wrap_content"
41-
app:layoutManager="androidx.recyclerview.widget.LinearLayoutManager"/>
42+
app:layoutManager="androidx.recyclerview.widget.LinearLayoutManager" />
4243

4344
<TextView
44-
android:id="@+id/no_results"
45+
android:id="@+id/no_results_search"
4546
android:visibility="gone"
4647
android:layout_width="wrap_content"
4748
android:layout_height="wrap_content"
4849
android:text="@string/no_results_found"
49-
android:layout_gravity="center"/>
50+
android:layout_gravity="center" />
5051

5152
</com.google.android.material.search.SearchView>
5253

53-
<GridLayout
54-
android:id="@+id/viewToShow"
55-
android:layout_width="match_parent"
54+
<TextView
55+
android:id="@+id/no_results"
56+
android:visibility="gone"
57+
android:layout_width="wrap_content"
5658
android:layout_height="wrap_content"
57-
android:layout_gravity="center"
58-
android:useDefaultMargins="true"
59-
android:visibility="gone">
60-
61-
<de.davis.passwordmanager.ui.views.InformationView
62-
android:layout_width="match_parent"
63-
android:layout_height="wrap_content"
64-
app:contentEnabled="false"
65-
app:title="@string/no_elements_to_show">
66-
67-
<Button
68-
android:id="@+id/viewAddFirst"
69-
android:layout_width="match_parent"
70-
android:layout_height="wrap_content"
71-
android:layout_marginTop="@dimen/default_margin"
72-
android:text="@string/add_element" />
73-
</de.davis.passwordmanager.ui.views.InformationView>
74-
</GridLayout>
59+
android:text="@string/no_results_found"
60+
android:layout_gravity="center" />
7561

7662

7763
<com.google.android.material.progressindicator.LinearProgressIndicator
7864
android:id="@+id/progress"
7965
android:layout_width="wrap_content"
8066
android:layout_height="wrap_content"
8167
android:layout_gravity="center_horizontal"
82-
android:indeterminate="true"/>
68+
android:indeterminate="true" />
8369

8470
</androidx.coordinatorlayout.widget.CoordinatorLayout>

0 commit comments

Comments
 (0)