Fix for Issue #12 - Handle long master passwords #13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This pull request fixes issue #12, which involves a crash occurring when logging into the app with a long master password. The crash is caused by the bcrypt algorithm's inability to handle passwords longer than 72 characters. To mitigate this issue, the proposed solution is to first hash the password using the SHA-512 algorithm and then compare it with the original hashed password.
Changes Made:
LongPasswordStrategyusingLongPasswordStrategies.hashSha512(VERSION_2A)Impact:
Related Issues:
Issue #12
Additional Notes:
The changes made in this pull request adhere to the best practices and security guidelines for password handling. The updated password handling mechanism ensures both security and stability while maintaining compatibility with the bcrypt algorithm for shorter passwords.