[Feature] Tag #23
Merged
[Feature] Tag #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces the Tag entity, enhancing the database's capability to store and manage relationships between tags and secure elements. Additionally, this update includes the conversion of certain classes to Kotlin. Leveraging Kotlin's coroutine support provides a more streamlined and efficient approach, aligning with modern best practices for asynchronous programming.
This commit implements a user interface element, empowering users to create and assign custom tags to their elements seamlessly.
This allows for better comparisons/equality checks between two SecureElement objects
Implemented the doFlowInLifecycle extension function. This function enhances UI state management by ensuring that Kotlin flows are handled in accordance with the lifecycle state of the component, thus providing more efficient and safer UI updates.
Implemented enhancements in EditDialogBuilder to allow setting custom button listeners that do not automatically dismiss the dialog upon execution. This modification provides more control over the dialog's behavior during user interactions.
…dling Refined withSelectionPredicate in SelectionTracker to disallow operations on default tags like 'Password'. This change ensures critical tags remain protected from actions like deletion or renaming, enhancing data integrity and user experience.
Refactored the setButtonListener logic in EditDialogBuilder to include additional validations for tag editing. Now, the updated code checks for blank inputs and unchanged tag names. This enhancement streamlines user input handling and prevents unnecessary database operations, contributing to a more robust and user-friendly tag management experience.
Introduced a new preference setting enabling users to toggle between tag view and classic element list view in the dashboard. This enhancement offers a customizable user experience, catering to diverse user preferences for dashboard display.
Included a new ProGuard rule to preserve classes implementing the ElementDetail interface. This ensures crucial functionalities related to database entities remain intact during the code obfuscation process.
Updated the build configuration with a ksp block to enable Kotlin source generation for Room database operations. This addition optimizes the integration of Room with Kotlin, ensuring more efficient and type-safe database interactions.
Updated the DAO function with the @transaction annotation to optimize database operations. This change not only improves efficiency but also resolves an issue related to view reloading, enhancing overall application performance and reliability.
The migration process is enhanced with logic to handle tag insertion and association, ensuring data integrity and consistency post-migration.
Could have caused a problem setting tags directly via the constructor -> default tags would not have been set
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.