add a comment to clarify the reason of using CompletableFuture

OneSignal · Aug 1, 2024 · 02e30e1 · 02e30e1
1 parent 18dd0d5
commit 02e30e1
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/...es/OneSignalDemo/app/src/main/java/com/onesignal/sdktest/application/MainApplication.java b/...es/OneSignalDemo/app/src/main/java/com/onesignal/sdktest/application/MainApplication.java
@@ -61,7 +61,8 @@ public void onCreate() {
 
  OneSignal.initWithContext(this, appId);
 
- // ensure calling requestPermission in a thread right after initWithContext does not crash
+ // Ensure calling requestPermission in a thread right after initWithContext does not crash
+ // This will reproduce result similar to Kotlin CouroutineScope.launch{}, which may potentially crash the app
  ExecutorService executor = Executors.newSingleThreadExecutor();
  @SuppressLint({"NewApi", "LocalSuppress"}) CompletableFuture<Void> future = CompletableFuture.runAsync(() -> {
  OneSignal.getNotifications().requestPermission(true, Continue.none());