From 02e30e113f011632881a199d7c9d784689e3d8b1 Mon Sep 17 00:00:00 2001
From: jinliu9508 <jinliu9508@gmail.com>
Date: Thu, 1 Aug 2024 15:17:27 -0400
Subject: [PATCH] add a comment to clarify the reason of using
 CompletableFuture

---
 .../com/onesignal/sdktest/application/MainApplication.java     | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/Examples/OneSignalDemo/app/src/main/java/com/onesignal/sdktest/application/MainApplication.java b/Examples/OneSignalDemo/app/src/main/java/com/onesignal/sdktest/application/MainApplication.java
index f7759835f..3050d96fc 100644
--- a/Examples/OneSignalDemo/app/src/main/java/com/onesignal/sdktest/application/MainApplication.java
+++ b/Examples/OneSignalDemo/app/src/main/java/com/onesignal/sdktest/application/MainApplication.java
@@ -61,7 +61,8 @@ public void onCreate() {
 
         OneSignal.initWithContext(this, appId);
 
-        // ensure calling requestPermission in a thread right after initWithContext does not crash
+        // Ensure calling requestPermission in a thread right after initWithContext does not crash
+        // This will reproduce result similar to Kotlin CouroutineScope.launch{}, which may potentially crash the app
         ExecutorService executor = Executors.newSingleThreadExecutor();
         @SuppressLint({"NewApi", "LocalSuppress"}) CompletableFuture<Void> future = CompletableFuture.runAsync(() -> {
             OneSignal.getNotifications().requestPermission(true, Continue.none());