Fix Firebase Messaging 22.0.0 Compatibility for 3.x.x branch #1348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Move the implementation of getToken into it's own method. - Allows us to add another implementation in a follow up commit
* New getTokenWithClassFirebaseMessaging method that uses the newer FirebaseMessaging.getToken() API added in firebase-messaging:21.0.0. * Since all apps may not have updated to firebase-messaging:21.0.0 or newer we are catching NoClassDefFoundError & NoSuchMethodError and falling back to FirebaseInstanceId.getToken
* Since we can't bump firebase-messaging high enougth to get the FirebaseMessaging.getToken method compile with we are instead calling it with reflection. * We can't bump any higher as this would interduce AndroidX which would interduce breaking changes we can't do on this 3.x.x branch.
* Older versions of firebase-messaging such as 19 have this method but will return null.
Jeasmine
approved these changes
May 26, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Same as PR #1340 expect for this 3.x.x branch to back port.
Details
First 3 commits were cherry picked from the master branch version of this PR. However instead of using reflection on the old firebase-messaging API we had to write new code to use reflection on the new API. This is due to the fact we can't upgrade firebase-messaging on this 3.x.x patch branch as it would introduce a dependency on AndroidX.
This change is