Feature App-defined Language implementation backported to 3.X.X version #1350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added Language Context Interface for getter and setter for Language Provider * Added classes Language Provider, LanguageProviderAppDefined and LanguageProviderDevice * The interface retrieves the default language set by device if a language override is not set
* Fixed the null check in the LanguageContext class * Added getLanguage method to retrieve the language from strategy
* added network call to setLanguage method in OneSignal class * Updated device info to retrieve language from LanguageContext class * Added SET_LANGUAGE to OSTaskController String Array to execute task delays
* Added a Unit test to test setLanguage method executing during the initialization of OneSignal library * Added a Unit test to test setLanguage method executing after the OneSignal library has been initialized * Added a Unit test to test setLanguage method executing after a an app has been restarted and new session has been initialized
* Moved the implementation of OSUtils.getCorrectedLanguage to LanguageProviderDevice.getLanguage
* Made OneSignal.preferences public for accessibility in Language classes * Moved callbacks for OneSignalPrefs from LanguageContext and LanguageProviderAppDefined classes to OneSignal.preferences
* Fix OSInAppMessageController variantIdForMessage retrieves languageIndentifier from OneSignal languageContext * Fix NotificationChannelManager CreateChannel retrieves deviceLanguage from OneSignal languageContext
* Add Singleton pattern to LanguageContext class * Add OSSharedPreference dependency to LanguageProviderAppDefined constructor * Add OSSharedPreference dependency to LanguageContext constructor
* Add LanguageContext dependency to OSInAppMessageController constructor * Add LanguageContext dependency to OSInAppMessageControllerFactory constructor * Add LanguageContext dependency to OSInAppMessageDummyController * Rename languageIdentifier to language in OSInAppMessageController variantIdentifier
* Update NotificationChannelManager createChannel to use LanguageContext instance * Rename deviceLanguage variable to language for consistency
* Convert OneSignal preferences and OneSignal languageContext from public to private since they are being called through dependency injection
* Fix format space LanguageContext class * Fix format space LanguageProviderAppDefined class * Fix format space LanguageProviderDevice class
* Remove unnecessary null check at OneSignal.setLanguage * Remove error logging at JSONException catch at OneSignal.setLanguage
…Language * Add OneSignal.initWithContext to NotificationChannelManagerRunner.processChannelListWithMultiLanguage to allow languageContext to initialize before using languageContext.getLanguage
* Add NonNull annotation to getLanguage implementations in LanguageProviderDevice, LanguageProviderAppDefined and LanguageContext classes
* Move "en" string to constant in LanguageProviderAppDefined class * Move Corrected Language Strings to constant in LanguageProviderDevice class * Add OSTaskRemoteController.SET_LANGUAGE in place of setLanguage() string in OneSignal.setLanguage
* Move preferences.getString to variable instead of if statement for clarity in LanguageContext constructor
jkasten2
requested changes
May 28, 2021
There was a problem hiding this comment.
Remove .ds_store file
Reviewed 13 of 13 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @emawby, @Jeasmine, and @tanaynigam)
OneSignalSDK/onesignal/src/main/java/com/onesignal/OneSignal.java, line 745 at r1 (raw file):
// Initialize languageContext languageContext = new LanguageContext(preferences);
We are already creating an instance of setAppContext so we should remove this one.
emawby
approved these changes
Jun 1, 2021
There was a problem hiding this comment.
Reviewed 13 of 13 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Jeasmine and @tanaynigam)
Jeasmine
approved these changes
Jun 1, 2021
jkasten2
approved these changes
Jun 2, 2021
There was a problem hiding this comment.
Reviewed 2 of 2 files at r2.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @tanaynigam)
* Replace androidx imports to android.support imports in LanguageContext, LanguageProviderDevice, LanguageAppDefined classes and LanguageProvider interface
* Move order of class initializations of classes LanguageProviderAppDefined, LanguageContext * Move order of run command of runnable runSetLanguage
* Fix OSInAppMessageController.htmlPathForMessage to non-static
* Fix NotificationChannelManagerRunner.processChannelListWithMultiLanguage to use OneSignal.startInit * Remove time variable from MainOneSignalClassRunner.testSetLanguageOnSession function restartAppAndElapseTimeToNextSession
* Add languageContext initialization to OneSignal.setAppContext to allow languageContext initialization to run when app is initialized via context.
* Add simulated delay to FCM/GCM providing a push token which delays the /player CREATE network call in MainOneSignalClassRunner.testSetLanguageOnPlayerCreate and MainOneSignalClassRunner.testSetLanguageOnSession unit tests
* Remove unnecessary languageContext initialization from OneSignal.init
* Replace startInit with setAppContext in NotificationChannelManagerRunner.processChannelWithMultiLanguage
tanaynigam
force-pushed
the
feat/set_language_for_3.X.X
branch
from
0c0e704
to
678ff8b
Compare
jkasten2
approved these changes
Jun 3, 2021
There was a problem hiding this comment.
Reviewed 1 of 1 files at r3.
Reviewable status:
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add feature app-defined language implementation. A user can define their own language setting to be used by OneSignal-SDK version 3.X.X. Cherry picked from OneSignal-SDK version 4.4.0 PR #1334
Details
LanguageContext,LanguageProviderAppDefinedandLanguageProviderDeviceclass andLanguageProviderinterfaceOneSignal.setLanguageimplementationrunSetLanguagerunnable toOneSignal.setLanguagefor network call implementation. Add runnable to addTaskToQueueTest
This change is