Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make UserStateSMSSynchronizer package-private #1491

Merged
merged 1 commit into from
Nov 18, 2021

Conversation

jkasten2
Copy link
Member

@jkasten2 jkasten2 commented Nov 17, 2021

Description

One Line Summary

Change UserStateSMSSynchronizer access from public to package-private.

Details

Motivation

This class wasn't indented to be public and no public API exposes this class. Also Xamarin inspects this type with it's class-parse implementation which results in errors.

Testing

Manual testing

Tested with a Xamarin Android Binding project with the class-parse setting.

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
  • I have reviewed this PR myself, ensuring it meets each checklist item

This change is Reviewable

This class wasn't intented to be public, marking it as package-private.
@jkasten2 jkasten2 merged commit 67132f8 into main Nov 18, 2021
@jkasten2 jkasten2 deleted the fix/make_UserStateSMSSynchronizer_package-private branch November 18, 2021 01:38
@jkasten2 jkasten2 mentioned this pull request Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants