Don't set backgroundImageLayout if device is Android 12 or higher #1495
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Don't set backgroundImageLayout if device is Android 12 or higher
Details
Documentation for Android Background Images
We currently add the backgroundImageLayout in the addBackgroundImage method of
GenerateNotification.java
We are now checking for the device SDK version being less than 31 (s) and returning early if >= 31.
Motivation
Android 12+ changed the "Customizable Area" within notifications. So background images will look different and we recommend creating your own custom layout to handle this. Therefore we have decided to disable background image layouts for devices on Android 12+.
Scope
Notification appearance for Android 12+ devices only.
Testing
Unit testing
OPTIONAL - Explain unit tests added, if not clear in the code.
Manual testing
RECOMMEND - OPTIONAL - Explain what scenarios were tested and the environment.
Example: Tested opening a notification while the app was foregrounded, app build with Android Studio 2020.3 with a fresh install of the OneSignal example app on a Pixel 6 with Android 12.
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is