Fix Heads-Up Displaying Previous Notification When Grouped on some devices #1578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using GROUP_ALERT_CHILDREN with setGroupAlertBehavior means the just receive notification will be used as the heads-up, if the notification channel is configured for highest display priority. Before with GROUP_ALERT_SUMMARY, you would see a summary of all notifications in the group which was much harder to see the most recent. This also fixes a bug where the previous notification would be shown as the heads-up notification on some devices. Such as Samsung's OneUI 4 with the Brief style of notifications, as well as some other manufacturers. Lastly the bug would sometimes happen on Android 7 and 8 AOSP since the summary and child notification are posted at the same time and these versions of Android would pick one at random. In this case it seemed to only be an issue when setting android_group and only on the 2nd notification display.
jkasten2
changed the title
After testing Android 6 in the Android Studio emulator it was found that using setGroupAlertBehavior with GROUP_ALERT_CHILDREN breaks the heads-up and sound for notifications that are grouped. Since the GROUP_ALERT_CHILDREN flag is required for newer versions of Android to fix a different bug with heads up notifications from showing old notifications in the group we needed to add an Android version runtime check to select the correct flag. We could report this bug to Google and they might be able to fix it in a future AndroidX release however due to the age of Android 6 and it's limitations it is unlikely it will be fixed. So this workaround will mostly likely need to stay in place until we drop support for Android 6. See the last commit for more details on why GROUP_ALERT_CHILDREN is needed for Android 8+. This also addresses the failing test form the last commit.
jkasten2
force-pushed
the
fix/grouped_heads_up_showing_last
branch
from
72d207f
to
2a11fcf
Compare
jkasten2
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Some devices would display the previous notification as a heads-up notification when they become grouped which this PR addresses.
Details
Motivation
The main motivation is to fix the bug noted above. Secondary is this changes the heads-up notification from showing the group summary to showing the most recent notification. This makes it much easier to see what is new instead of it being mixed with older notifications. Video below will show this behavior difference.
Scope
Only effects the display of grouped heads-up notifications for Android 7.0 and newer.
Background details - Android features
Google's documentation on specific Android Notification features referenced in this PR:
Details of the change
Using
GROUP_ALERT_CHILDRENwithsetGroupAlertBehaviormeans the just receive notification will be used as the heads-up notification. BeforeGROUP_ALERT_SUMMARYwould result in seeing a summary of all notifications in the group.This also fixes a bug where the previous notification would be shown as the heads-up notification on some devices. Such as Samsung's OneUI 4 with the Brief style of notifications, as well as some other manufacturers.
Lastly the bug would sometimes happen on Android 7 and 8 AOSP since the summary and child notification are posted at the same time and these versions of Android would pick one at random. In this case it seemed to only be an issue when setting
android_groupand only on the 2nd notification display.Fixes #1574
Testing
Unit testing
None, this is a visual change
Manual testing
Tested on Android Studio Emulators:
Test on device:
Videos
Android 12 Emulator
Before
Android_headsup_as_summary.mp4
After
Android_headsup_set_as_child.mp4
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is