Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[User Model] Huawei Fixes #1742

Merged
merged 2 commits into from
Mar 14, 2023
Merged

Conversation

brismithers
Copy link
Contributor

@brismithers brismithers commented Mar 6, 2023

Description

One Line Summary

Minor updates to ensure user model is working with Huawei

Details

Motivation

A more thorough vetting of Huawei devices surfaced some issues with the HMS-specific logic. Appropriate updates were made. Additionally, the example app build gradle has been updated to support more easier Huawei testing for OneSignal internal use.

Testing

Manual testing

Tested example app on Android emulator with HMS Core installed to drive basic functionality.
Deployed example app to Huawei device to drive more thoroughly.

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

This change is Reviewable

…nd signing config for Huawei.

* Remove coroutine launch when registering for HMS push token.
@brismithers brismithers merged commit ff3081e into user-model/main Mar 14, 2023
@brismithers brismithers deleted the user-model/huawei-fixes branch March 14, 2023 17:19
@emawby emawby mentioned this pull request May 1, 2023
jinliu9508 pushed a commit that referenced this pull request Jan 31, 2024
jinliu9508 pushed a commit that referenced this pull request Jan 31, 2024
jinliu9508 pushed a commit that referenced this pull request Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant