Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump firebase-messaging dependency version #1762

Merged
merged 1 commit into from
Apr 13, 2023

Conversation

jennantilla
Copy link
Contributor

@jennantilla jennantilla commented Apr 13, 2023

Description

One Line Summary

Bump firebase-messaging dependency version

Details

Motivation

As reported in #1759, a Firebase issue was causing apps to crash. Firebase released a fix for this in 23.0.0, so OneSignal needed to update our firebase-messaging dependency from 22.0.99 to 23.0.99.

Fixes #1759

Testing

Unit testing

N/A

Manual testing

Unable to reproduce original issue reported in #1759, but ran app with updated dependency and no issues were observed.

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

This change is Reviewable

Copy link
Member

@jkasten2 jkasten2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @emawby and @nan-li)

@jennantilla jennantilla merged commit d1fa9e7 into main Apr 13, 2023
@jennantilla jennantilla deleted the fix/firebase_messaging_dependency branch April 13, 2023 22:53
@jkasten2 jkasten2 mentioned this pull request May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Not allowed to bind to service Intent
3 participants