Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update high level components to be accessed via pascal case #1764

Merged
merged 1 commit into from
Apr 18, 2023

Conversation

brismithers
Copy link
Contributor

@brismithers brismithers commented Apr 17, 2023

Description

One Line Summary

Update high level components to be accessed via pascal casing.

Details

Motivation

To keep consistent, make all high level components accessible via a property that is in pascal case (i.e. OneSignal.Notifications, OneSignal.InAppMessages, etc). This is in contradiction to Kotlin best practices, but is favored to keep access patterns consistent across the SDK.

Scope

This is name change only, no functional changes.

Testing

Manual testing

No testing was performed. The codebase compiles, and existing unit tests pass.

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

This change is Reviewable

Copy link
Contributor

@iAmWillShepherd iAmWillShepherd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@jkasten2 jkasten2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @emawby, @jennantilla, @nan-li, and @shepherd-l)

@brismithers brismithers merged commit e7c9594 into user-model/main Apr 18, 2023
@brismithers brismithers deleted the user-model/pascal-case-areas branch April 18, 2023 21:25
@emawby emawby mentioned this pull request May 1, 2023
jinliu9508 pushed a commit that referenced this pull request Jan 31, 2024
Update high level components to be accessed via pascal case
jinliu9508 pushed a commit that referenced this pull request Jan 31, 2024
Update high level components to be accessed via pascal case
jinliu9508 pushed a commit that referenced this pull request Feb 6, 2024
Update high level components to be accessed via pascal case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants