Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Don't retry IAM display if 410 is received from backend #2158

Merged
merged 3 commits into from
Aug 5, 2024
Merged

Fix: Don't retry IAM display if 410 is received from backend #2158

merged 3 commits into from
Aug 5, 2024

Commits on Jul 30, 2024

  1. Remove IAM from messages list if 410 is reached 

    - Changed `messages` from an immutable list to a mutable list
    @jennantilla
    jennantilla committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    f9620c1 View commit details
    Browse the repository at this point in the history

  2. Ensure thread-safe access to messages list 

    - Added synchronization to `makeRedisplayMessagesAvailableWithTriggers` and `attemptToShowInAppMessage` to prevent concurrent modification issues
- Refactored `evaluateInAppMessages` to collect messages for display inside a synchronized block and process them outside to avoid suspension points within critical sections
    @jennantilla
    jennantilla committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    7e0e6bc View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2024

  1. Refactor synchronization lock 

    - Changed `synchronized(lock)` to `synchronized(messages)`
    @jennantilla
    jennantilla committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    5f5c4c0 View commit details
    Browse the repository at this point in the history