Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Importance fallback fix for notification channels #639

Merged
merged 1 commit into from
Oct 5, 2018

Conversation

jkasten2
Copy link
Member

@jkasten2 jkasten2 commented Oct 4, 2018

  • If the Android Oreo notification channel has a Medium importance or lower
    we now correctly skip setting sound, led, and vibration settings for pre-Oreo devices.
  • Refactored these setting into a new setAlertnessOptions method to group this logic.

This change is Reviewable

* If the Android Oreo notification channel has a Medium importance or lower
    we now correctly skip setting sound, led, and vibration settings for pre-Oreo devices.
* Refactored these setting into a new setAlertnessOptions method to group this logic.
Copy link
Contributor

@Nightsd01 Nightsd01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jkasten2 jkasten2 merged commit dddd03b into master Oct 5, 2018
@jkasten2 jkasten2 deleted the fix_notification_channel_importance_fallback branch October 5, 2018 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants