Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added result to GCM broadcast aborts #642

Merged
merged 2 commits into from
Oct 5, 2018
Merged

Added result to GCM broadcast aborts #642

merged 2 commits into from
Oct 5, 2018

Conversation

jkasten2
Copy link
Member

@jkasten2 jkasten2 commented Oct 5, 2018 •
edited
Loading

  • Adding a result prevents the GMS app from putting a confusing CANCELLED entry into the logcat.

This change is Reviewable

@jkasten2
Added result to GCM broadcast aborts
dffed17 
* Adding a result prevents the GMS  app from putting a confusing CANCELLED entry into the logcat.
Nightsd01
Nightsd01 approved these changes Oct 5, 2018
View reviewed changes
Copy link
Contributor

@Nightsd01 Nightsd01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jkasten2 jkasten2 merged commit d2225c3 into master Oct 5, 2018
@jkasten2 jkasten2 deleted the gcm_result_with_abort branch October 5, 2018 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nightsd01 Nightsd01 Nightsd01 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jkasten2 @Nightsd01