Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-expose notificationPermissionStatus #450

Merged
merged 1 commit into from
Aug 2, 2021
Merged

Re-expose notificationPermissionStatus #450

merged 1 commit into from
Aug 2, 2021

Conversation

westy92
Copy link
Contributor

@westy92 westy92 commented Jul 29, 2021

This was exposed in the past but appears to have been hidden with the 3.x refactor.

I also added OSNotificationPermission.ephemeral to match the underlying platform SDKs.


This change is Reviewable

Copy link
Contributor

@Jeasmine Jeasmine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! ty for the contribution

@Jeasmine Jeasmine merged commit 625d40f into OneSignal:main Aug 2, 2021
@westy92 westy92 deleted the expose-nps branch August 2, 2021 21:17
@blackchineykh
Copy link

When can we expect to have this one resolved and merged?

@Jeasmine Jeasmine mentioned this pull request Aug 5, 2021
@westy92
Copy link
Contributor Author

westy92 commented Aug 11, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants