Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make license file compatible with tools like LicenseBat #527

Merged
merged 1 commit into from
Jan 28, 2022

Conversation

iAmWillShepherd
Copy link
Contributor

@iAmWillShepherd iAmWillShepherd commented Jan 12, 2022

Fixes #526

This PR de-nests the license copy from a multi-line comment. I believe this is causing issues with tools that attempt to parse a license file to determine the license type.

MIT license templates:


This change is Reviewable

According to https://choosealicense.com/licenses/mit/, the proper formatting for a license file is not as a multi-line comment.
@iAmWillShepherd
Copy link
Contributor Author

The build is broken because PR #524 isn't merged yet.

Copy link
Member

@jkasten2 jkasten2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Jeasmine)

@iAmWillShepherd iAmWillShepherd requested review from a team January 21, 2022 21:50
@jkasten2 jkasten2 merged commit 0aa1b1b into main Jan 28, 2022
@jkasten2 jkasten2 deleted the license-file-formatting branch January 28, 2022 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

License type MIT not recognise
3 participants