Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix calling setLaunchUrlsInApp after init #1043

Merged
merged 1 commit into from
Jan 29, 2022

Conversation

emawby
Copy link
Contributor

@emawby emawby commented Jan 28, 2022

Description

One Line Summary

This allows setLaunchUrlsInApp to have an effect after init has been called

Details

launchURL behavior used to be a part of the init call in the previous major release. When the init call was split apart in the 3.0.0 major release the setLaunchUrlsInApp logic only worked if it was called prior to init because it set values in the appSettings dictionary instead of calling enableInAppLaunchUrls directly.

Testing

Manual testing

Tested setLaunchUrlsInApp true and false before and after init

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes
  • Distribution

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
  • I have reviewed this PR myself, ensuring it meets each checklist item

This change is Reviewable

This allows setLaunchUrlsInApp to have an effect after init has been called. Previously calling it after init would have no effect.
@emawby emawby requested a review from a team January 28, 2022 20:14
@emawby emawby merged commit 149fb03 into main Jan 29, 2022
@emawby emawby deleted the fix/setLaunchUrlsInApp_after_init branch January 29, 2022 00:33
@emawby emawby mentioned this pull request Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants