Fix calling setLaunchUrlsInApp after init #1043
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
This allows setLaunchUrlsInApp to have an effect after init has been called
Details
launchURL behavior used to be a part of the init call in the previous major release. When the init call was split apart in the 3.0.0 major release the setLaunchUrlsInApp logic only worked if it was called prior to init because it set values in the appSettings dictionary instead of calling enableInAppLaunchUrls directly.
Testing
Manual testing
Tested setLaunchUrlsInApp true and false before and after init
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is