Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Forward Target Swizzling check for UNUserNotificationCenterDelegate methods #1097

Merged
merged 3 commits into from
May 25, 2022

Conversation

emawby
Copy link
Contributor

@emawby emawby commented May 25, 2022

Description

One Line Summary

Use the new Swizzling Forwarder class to check for forwardingSelectors when looking for original implementors of UNUserNotificationCenterDelegate methods.

Details

PR #1091 Adding the SwizzlingForwarder class that checks to see if there is a forwardingTarget for selectors when trying to call original implementations of our swizzled methods. That PR added the behavior for AppDelegate methods but not for UNUserNotificationCenterDelegate methods. This PR adds the behavior for UNUserNotificationCenterDelegate methods.

Motivation

Apps or other frameworks could be using forwardingTargets for UNUserNotificationCenterDelegate methods, and with our current swizzling implementation we would not properly forward those calls on.

Scope

iOS SDK method swizzling

Testing

Unit testing

Added unit tests for the forwarding targets, infinite loop test, and existing selectors

Manual testing

tested on my iOS device

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

This change is Reviewable

We will now look for the forwarding target for willPresentNotification and didReceiveNotificationResponse on the UNUserNotificationCenter.
@emawby emawby requested review from jkasten2 and nan-li May 25, 2022 20:10
Copy link
Member

@jkasten2 jkasten2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @nan-li)

@emawby emawby merged commit 2879e22 into main May 25, 2022
@emawby emawby deleted the swizzle_forward_target_usernotificationcenter branch May 25, 2022 21:22
@emawby emawby mentioned this pull request Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants