Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing cold restart tracking #1103

Merged
merged 1 commit into from
Jun 2, 2022
Merged

Removing cold restart tracking #1103

merged 1 commit into from
Jun 2, 2022

Conversation

emawby
Copy link
Contributor

@emawby emawby commented Jun 2, 2022

Description

One Line Summary

Removing our call to track cold restarts via the /track endpoint

Details

Once User Model is released we will use a new end point for getting IAMs, and our old SDK versions will still be gathering this data. I am leaving the method to do the tracking in the SDK in case we want to add it back in the future, but it is no longer being called.

Motivation

We no longer need to be hitting our /track endpoint to track cold restarts. Our existing SDKs will get us data, and with user model we will change when IAMs are pulled down, which was the original reason for wanting to gather this data.

Scope

no longer hitting /track for cold restarts

Testing

Unit testing

no change

Manual testing

tested on my iPhone

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

This change is Reviewable

Once User Model is released we will use a new end point for getting IAMs, and our old SDK versions will still be gathering this data.
@emawby emawby requested review from jkasten2 and nan-li June 2, 2022 19:04
Copy link
Member

@jkasten2 jkasten2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @nan-li)

@emawby emawby merged commit f55808d into main Jun 2, 2022
@emawby emawby deleted the remove_cold_restart_tracking branch June 2, 2022 19:38
@emawby emawby mentioned this pull request Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants