Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix xcode 14 warnings and build failure #1132

Merged
merged 2 commits into from
Oct 17, 2022

Conversation

emawby
Copy link
Contributor

@emawby emawby commented Oct 13, 2022

Description

One Line Summary

fixes #1113
This PR makes fixes related to using Xcode 14.

Details

The two fixes in this pr are

  1. Fixing build failure due to compiling for the armv7s architecture
    For this fix we will remove the armv7s archicture from builds
  2. Fixing a UI thread block warning due to calling locationServicesEnabled on the main thread.
    Running locationServicesEnabled on the main thread causes an Xcode warning in Xcode 14 about a potential UI holdup.
    However the location manager class needs to be created and run on a thread with a runloop or it's updates won't come
    through. To handle this we will do locationServicesEnabled on a background thread and location fetch on main thread

Motivation

Xcode 14 warnings

Scope

build architecture and location services

Testing

Unit testing

Updated location unit tests to account for async location fetch

Manual testing

tested location services on a physical iOS device

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes
  • Location

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

This change is Reviewable

This is causing a build failure in Xcode 14 since armv7s is deprecated
@emawby emawby changed the title Fix xcode 14 warnings and build failure WiP Fix xcode 14 warnings and build failure Oct 13, 2022
running locationServicesEnabled on the main thread causes an Xcode warning in Xcode 14 about a potential UI holdup. However the location manager class needs to be created and run on a thread with a runloop or it's updates won't come through. To handle this we will do locationServicesEnabled on a background thread and location fetch on main thread
@emawby emawby force-pushed the fix/xcode_14_warnings_and_build_fail branch from 7708b01 to 0102f9a Compare October 13, 2022 22:13
@emawby emawby changed the title WiP Fix xcode 14 warnings and build failure Fix xcode 14 warnings and build failure Oct 13, 2022
Copy link
Member

@jkasten2 jkasten2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @fhboswell, @jennantilla, and @nan-li)

@emawby emawby merged commit 1f5ae96 into main Oct 17, 2022
@emawby emawby deleted the fix/xcode_14_warnings_and_build_fail branch October 17, 2022 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iOS16 beta :: warning This method can cause UI unresponsiveness if invoked on the main thread.
5 participants