Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Remove IAM window when an in app message is inactive #1413

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

emawby
Copy link
Contributor

@emawby emawby commented Apr 19, 2024

Description

One Line Summary

Fix a case where failing to load message content due to the IAM being inactive can freeze the app

Details

If we fail to load message content we were not removing the IAM window resulting in a "frozen" app with an un-interactable clear window overtop of the app.

The fix is to simply clean up the window if the message is inactive

Motivation

bug fix

Scope

IAMs that fail to load content

Testing

Unit testing

n/a

Manual testing

manually tested by forcing the IAM content load to fail
Also experienced it when testing another fix

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

This change is Reviewable

@emawby emawby merged commit f373135 into main Apr 22, 2024
4 checks passed
@emawby emawby deleted the iam_not_active_fix branch April 22, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants