Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Make null values safe for IAM requests #1457

Merged
merged 3 commits into from
Jul 1, 2024

Commits on Jun 27, 2024

  1. Make null values safe for IAM request payload

    * If subscription ID (most common) or other properties such as app ID are `nil`, the app crashes when requests for IAM impressions or clicks are created.
    * The app will crash with Exception `[__NSPlaceholderDictionary initWithObjects:forKeys:count:]: attempt to insert nil object from objects[1]`
    * Use a null-safe dictionary that will omit the entry if the value is null
    * We choose to send these requests so we have record of 400-ing requests
    nan-li committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    2e591de View commit details
    Browse the repository at this point in the history
  2. [tests] Add IAM Request tests

    * Add test module for In App Messages
    * Add request tests for In App Messages including when some properties can be null
    * And port over 2 existing IAM request tests
    nan-li committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    fcf9496 View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2024

  1. Configuration menu
    Copy the full SHA
    f8b8c65 View commit details
    Browse the repository at this point in the history