Always create new player ids on app install

[emawby]

This pr removes the usage of identifierForVendor to prevent creating a new player id for a reinstalled app.

This change is 

[jkasten2]

Reviewed 2 of 2 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @emawby and @Jeasmine)

---

iOS_SDK/OneSignalSDK/Source/OSUserState.h, line 37 at r1 (raw file):

@property (strong, nonatomic, readwrite, nullable) NSString *timezoneId;
//This property is no longer being populated with vendor id
@property (strong, nonatomic, readwrite, nullable) NSString *adId;

Can we just delete the property completely?

[emawby]

Reviewable status: 1 of 3 files reviewed, 1 unresolved discussion (waiting on @Jeasmine and @jkasten2)

---

iOS_SDK/OneSignalSDK/Source/OSUserState.h, line 37 at r1 (raw file):

Previously, jkasten2 (Josh Kasten) wrote…

Can we just delete the property completely?

I was concerned about wrappers expecting it but it looks like they never access it so I removed it completely

[jkasten2]

Reviewed 2 of 2 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Jeasmine and @jkasten2)

[emawby]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Jeasmine and @jkasten2)

---

iOS_SDK/OneSignalSDK/Source/OSUserState.h, line 37 at r1 (raw file):

Previously, emawby (Elliot Mawby) wrote…

I was concerned about wrappers expecting it but it looks like they never access it so I removed it completely

Done.