Fix clearing badge count on reinstall #939
Conversation
When reinstalling an app that previously had badges they are not cleared until the user has been prompted and accepts push permissions with badges. If the app doesn't have badge permissions we should be clearing the badges.
Since we no longer ask for the notif permission status when trying to clear badges the observer only fires twice, and the permission status is never set to denied.
There was a problem hiding this comment.
Badges were not being cleared on app reinstall until the user was prompted for push permissions, because we were checking for badge permissions before clearing badges.
I was pretty sure badges were cleared when you uninstall the app then reinstall it on iOS. Also I think if you tried to set applicationIconBadgeNumber without permission it shows a warning in the Xcode log, maybe only if it is a non-zero value though.
Reviewable status: 0 of 2 files reviewed, all discussions resolved (waiting on @Jeasmine)
There was a problem hiding this comment.
Regardless if this fixes the actual issue in question I approve this PR as this is good clean up if the extra check is jsut unnecessary.
Reviewed 1 of 1 files at r1, 1 of 1 files at r2.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @Jeasmine)
Badges were not being cleared on app reinstall until the user was prompted for push permissions, because we were checking for badge permissions before clearing badges. We don't need permission to set the badge count to 0 and in fact if they don't have permission then we definitely should be setting it to 0.
This change affected a unit test that was trying to reproduce an iOS 10.2.1 issue where permissions would be set to denied when backgrounding on the push prompt. I am not sure if this change fixed the iOS 10.2.1 issue, but I modified the test so that it passes.
This change is